From d4c95232a788867ca10c6f56b0a8eb90ddc1bf6f Mon Sep 17 00:00:00 2001
From: KenTandrian <kenricktan11@gmail.com>
Date: Thu, 19 Feb 2026 11:35:50 +0700
Subject: [PATCH] feat(lib): make sort a viewChild signal

---
 .../account-balances.component.ts             | 23 +++++++++----------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/libs/ui/src/lib/account-balances/account-balances.component.ts b/libs/ui/src/lib/account-balances/account-balances.component.ts
index 4738407d7..9f2e639ac 100644
--- a/libs/ui/src/lib/account-balances/account-balances.component.ts
+++ b/libs/ui/src/lib/account-balances/account-balances.component.ts
@@ -13,9 +13,9 @@ import {
   OnChanges,
   OnInit,
   Output,
-  ViewChild,
   inject,
-  input
+  input,
+  viewChild
 } from '@angular/core';
 import {
   FormGroup,
@@ -66,7 +66,14 @@ export class GfAccountBalancesComponent implements OnChanges, OnInit {
   @Output() accountBalanceCreated = new EventEmitter<CreateAccountBalanceDto>();
   @Output() accountBalanceDeleted = new EventEmitter<string>();
 
-  @ViewChild(MatSort) sort: MatSort;
+  public readonly accountBalances =
+    input.required<AccountBalancesResponse['balances']>();
+  public readonly accountCurrency = input.required<string>();
+  public readonly accountId = input.required<string>();
+  public readonly displayedColumns: string[] = ['date', 'value', 'actions'];
+  public readonly locale = input(getLocale());
+  public readonly showActions = input(true);
+  public readonly sort = viewChild(MatSort);
 
   public accountBalanceForm = new FormGroup({
     balance: new FormControl(0, (control) => Validators.required(control)),
@@ -77,14 +84,6 @@ export class GfAccountBalancesComponent implements OnChanges, OnInit {
     AccountBalancesResponse['balances'][0]
   >();
 
-  public readonly accountBalances =
-    input.required<AccountBalancesResponse['balances']>();
-  public readonly accountCurrency = input.required<string>();
-  public readonly accountId = input.required<string>();
-  public readonly displayedColumns: string[] = ['date', 'value', 'actions'];
-  public readonly locale = input(getLocale());
-  public readonly showActions = input(true);
-
   private dateAdapter = inject<DateAdapter<Date, string>>(DateAdapter);
   private notificationService = inject(NotificationService);
 
@@ -100,7 +99,7 @@ export class GfAccountBalancesComponent implements OnChanges, OnInit {
     if (this.accountBalances()) {
       this.dataSource = new MatTableDataSource(this.accountBalances());
 
-      this.dataSource.sort = this.sort;
+      this.dataSource.sort = this.sort();
       this.dataSource.sortingDataAccessor = get;
     }
   }