From d9f5e79a5d84ba9a782a966e97138e3e015c24bb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Germ=C3=A1n=20Mart=C3=ADn?= <github@gmartin.net>
Date: Thu, 20 Nov 2025 19:14:48 +0100
Subject: [PATCH] Feature/refactor validateAnonymousLogin to simplify promise
 handling

---
 apps/api/src/app/auth/auth.service.ts | 36 +++++++++++----------------
 1 file changed, 14 insertions(+), 22 deletions(-)

diff --git a/apps/api/src/app/auth/auth.service.ts b/apps/api/src/app/auth/auth.service.ts
index a6ee5d260..6fe50dce0 100644
--- a/apps/api/src/app/auth/auth.service.ts
+++ b/apps/api/src/app/auth/auth.service.ts
@@ -17,30 +17,22 @@ export class AuthService {
   ) {}
 
   public async validateAnonymousLogin(accessToken: string): Promise<string> {
-    return new Promise(async (resolve, reject) => {
-      try {
-        const hashedAccessToken = this.userService.createAccessToken({
-          password: accessToken,
-          salt: this.configurationService.get('ACCESS_TOKEN_SALT')
-        });
+    const hashedAccessToken = this.userService.createAccessToken({
+      password: accessToken,
+      salt: this.configurationService.get('ACCESS_TOKEN_SALT')
+    });
 
-        const [user] = await this.userService.users({
-          where: { accessToken: hashedAccessToken }
-        });
+    const [user] = await this.userService.users({
+      where: { accessToken: hashedAccessToken }
+    });
 
-        if (user) {
-          const jwt = this.jwtService.sign({
-            id: user.id
-          });
+    if (user) {
+      return this.jwtService.sign({
+        id: user.id
+      });
+    }
 
-          resolve(jwt);
-        } else {
-          throw new Error();
-        }
-      } catch {
-        reject();
-      }
-    });
+    throw new Error();
   }
 
   public async validateOAuthLogin({
@@ -75,7 +67,7 @@ export class AuthService {
     } catch (error) {
       throw new InternalServerErrorException(
         'validateOAuthLogin',
-        error.message
+        error instanceof Error ? error.message : 'Unknown error'
       );
     }
   }