From d9fd4c4f705e61bcf0fe2c9517b4113868050f35 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sun, 31 Dec 2023 14:05:47 +0100
Subject: [PATCH] Refactor to ordered list

---
 .../portfolio/analysis/analysis-page.html     | 88 ++++++++++---------
 1 file changed, 46 insertions(+), 42 deletions(-)

diff --git a/apps/client/src/app/pages/portfolio/analysis/analysis-page.html b/apps/client/src/app/pages/portfolio/analysis/analysis-page.html
index f875907bb..cc073ff62 100644
--- a/apps/client/src/app/pages/portfolio/analysis/analysis-page.html
+++ b/apps/client/src/app/pages/portfolio/analysis/analysis-page.html
@@ -41,31 +41,33 @@
           >
         </mat-card-header>
         <mat-card-content>
-          <div *ngFor="let position of top3; let i = index" class="py-1">
-            <a
-              class="d-flex"
-              [queryParams]="{
+          <ol class="mb-0 ml-1 pl-3">
+            <li *ngFor="let position of top3" class="py-1">
+              <a
+                class="d-flex"
+                [queryParams]="{
                 dataSource: position.dataSource,
                 positionDetailDialog: true,
                 symbol: position.symbol
               }"
-              [routerLink]="[]"
-            >
-              <div class="flex-grow-1 mr-2 text-truncate">
-                {{ i + 1 }}. {{ position.name }}
-              </div>
-              <div class="d-flex justify-content-end">
-                <gf-value
-                  class="justify-content-end"
-                  position="end"
-                  [colorizeSign]="true"
-                  [isPercent]="true"
-                  [locale]="user?.settings?.locale"
-                  [value]="position.netPerformancePercentage"
-                ></gf-value>
-              </div>
-            </a>
-          </div>
+                [routerLink]="[]"
+              >
+                <div class="flex-grow-1 mr-2 text-truncate">
+                  {{ position.name }}
+                </div>
+                <div class="d-flex justify-content-end">
+                  <gf-value
+                    class="justify-content-end"
+                    position="end"
+                    [colorizeSign]="true"
+                    [isPercent]="true"
+                    [locale]="user?.settings?.locale"
+                    [value]="position.netPerformancePercentage"
+                  ></gf-value>
+                </div>
+              </a>
+            </li>
+          </ol>
           <div>
             <ngx-skeleton-loader
               *ngIf="!top3"
@@ -87,31 +89,33 @@
           >
         </mat-card-header>
         <mat-card-content>
-          <div *ngFor="let position of bottom3; let i = index" class="py-1">
-            <a
-              class="d-flex"
-              [queryParams]="{
+          <ol class="mb-0 ml-1 pl-3">
+            <li *ngFor="let position of bottom3" class="py-1">
+              <a
+                class="d-flex"
+                [queryParams]="{
                 dataSource: position.dataSource,
                 positionDetailDialog: true,
                 symbol: position.symbol
               }"
-              [routerLink]="[]"
-            >
-              <div class="flex-grow-1 mr-2 text-truncate">
-                {{ i + 1 }}. {{ position.name }}
-              </div>
-              <div class="d-flex justify-content-end">
-                <gf-value
-                  class="justify-content-end"
-                  position="end"
-                  [colorizeSign]="true"
-                  [isPercent]="true"
-                  [locale]="user?.settings?.locale"
-                  [value]="position.netPerformancePercentage"
-                ></gf-value>
-              </div>
-            </a>
-          </div>
+                [routerLink]="[]"
+              >
+                <div class="flex-grow-1 mr-2 text-truncate">
+                  {{ position.name }}
+                </div>
+                <div class="d-flex justify-content-end">
+                  <gf-value
+                    class="justify-content-end"
+                    position="end"
+                    [colorizeSign]="true"
+                    [isPercent]="true"
+                    [locale]="user?.settings?.locale"
+                    [value]="position.netPerformancePercentage"
+                  ></gf-value>
+                </div>
+              </a>
+            </li>
+          </ol>
           <div>
             <ngx-skeleton-loader
               *ngIf="!bottom3"