From da7f7cb1f7617b566415677557d9fe081c766b38 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 15 Aug 2026 13:42:48 +0200 Subject: [PATCH] Fix missing currency conversion of dividends --- apps/api/src/app/portfolio/portfolio.controller.ts | 3 +-- apps/api/src/app/portfolio/portfolio.service.ts | 12 +++--------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/apps/api/src/app/portfolio/portfolio.controller.ts b/apps/api/src/app/portfolio/portfolio.controller.ts index 3b34ae83e..b2dd8b69a 100644 --- a/apps/api/src/app/portfolio/portfolio.controller.ts +++ b/apps/api/src/app/portfolio/portfolio.controller.ts @@ -352,8 +352,7 @@ export class PortfolioController { let dividends = this.portfolioService.getDividends({ activities, - groupBy, - userCurrency + groupBy }); if ( diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts index 2cbafc076..30eb53c59 100644 --- a/apps/api/src/app/portfolio/portfolio.service.ts +++ b/apps/api/src/app/portfolio/portfolio.service.ts @@ -358,21 +358,15 @@ export class PortfolioService { public getDividends({ activities, - groupBy, - userCurrency + groupBy }: { activities: Activity[]; groupBy?: GroupBy; - userCurrency: string; }): InvestmentItem[] { - let dividends = activities.map(({ currency, date, value }) => { + let dividends = activities.map(({ date, valueInBaseCurrency }) => { return { date: format(date, DATE_FORMAT), - investment: this.exchangeRateDataService.toCurrency( - value, - currency, - userCurrency - ) + investment: valueInBaseCurrency }; });