From dcbd9225daf151bfa886075ea99e84a7bad0c8d3 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sun, 24 May 2026 09:58:26 +0200 Subject: [PATCH] Task/improve promises in patchAssetProfileData() of admin service (#6938) Improve promises in patchAssetProfileData() --- apps/api/src/app/admin/admin.service.ts | 36 ++++++++++++++----------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/apps/api/src/app/admin/admin.service.ts b/apps/api/src/app/admin/admin.service.ts index ba338b5b9..0bf5c3925 100644 --- a/apps/api/src/app/admin/admin.service.ts +++ b/apps/api/src/app/admin/admin.service.ts @@ -576,8 +576,8 @@ export class AdminService { } try { - Promise.all([ - await this.symbolProfileService.updateAssetProfileIdentifier( + await Promise.all([ + this.symbolProfileService.updateAssetProfileIdentifier( { dataSource, symbol @@ -587,7 +587,7 @@ export class AdminService { symbol: newSymbol as string } ), - await this.marketDataService.updateAssetProfileIdentifier( + this.marketDataService.updateAssetProfileIdentifier( { dataSource, symbol @@ -599,12 +599,15 @@ export class AdminService { ) ]); - return this.symbolProfileService.getSymbolProfiles([ - { - dataSource: DataSource[newDataSource.toString()], - symbol: newSymbol as string - } - ])?.[0]; + const [updatedAssetProfile] = + await this.symbolProfileService.getSymbolProfiles([ + { + dataSource: DataSource[newDataSource.toString()], + symbol: newSymbol as string + } + ]); + + return updatedAssetProfile; } catch { throw new HttpException( getReasonPhrase(StatusCodes.BAD_REQUEST), @@ -650,12 +653,15 @@ export class AdminService { updatedSymbolProfile ); - return this.symbolProfileService.getSymbolProfiles([ - { - dataSource: dataSource as DataSource, - symbol: symbol as string - } - ])?.[0]; + const [updatedAssetProfile] = + await this.symbolProfileService.getSymbolProfiles([ + { + dataSource: dataSource as DataSource, + symbol: symbol as string + } + ]); + + return updatedAssetProfile; } }