Limit length for comment, search query and symbol

apps/api/src/app/endpoints/asset-profiles/asset-profiles.controller.ts

@@ -17,7 +17,7 @@ import {
 } from '@ghostfolio/common/interfaces';
 import { hasPermission } from '@ghostfolio/common/permissions';
 import { permissions } from '@ghostfolio/common/permissions';
-import { MarketDataPreset, RequestWithUser } from '@ghostfolio/common/types';
+import { RequestWithUser } from '@ghostfolio/common/types';
 
 import {
   Body,
@@ -27,7 +27,6 @@ import {
   HttpException,
   Inject,
   Param,
-  ParseIntPipe,
   Patch,
   Post,
   Query,
@@ -36,11 +35,12 @@ import {
 } from '@nestjs/common';
 import { REQUEST } from '@nestjs/core';
 import { AuthGuard } from '@nestjs/passport';
-import { AssetProfileSplit, DataSource, Prisma } from '@prisma/client';
+import { AssetProfileSplit, DataSource } from '@prisma/client';
 import { parseISO } from 'date-fns';
 import { StatusCodes, getReasonPhrase } from 'http-status-codes';
 
 import { AssetProfilesService } from './asset-profiles.service';
+import { GetAssetProfilesDto } from './get-asset-profiles.dto';
 
 @AllowDuringImpersonation()
 @Controller('asset-profiles')
@@ -56,14 +56,17 @@ export class AssetProfilesController {
   @HasPermission(permissions.accessAdminControl)
   @UseGuards(AuthGuard('jwt'), HasPermissionGuard)
   public async getAssetProfiles(
-    @Query('assetSubClasses') filterByAssetSubClasses?: string,
+    @Query()
-    @Query('dataSource') filterByDataSource?: string,
+    {
-    @Query('presetId') presetId?: MarketDataPreset,
+      assetSubClasses: filterByAssetSubClasses,
-    @Query('query') filterBySearchQuery?: string,
+      dataSource: filterByDataSource,
-    @Query('skip', new ParseIntPipe({ optional: true })) skip?: number,
+      presetId,
-    @Query('sortColumn') sortColumn?: string,
+      query: filterBySearchQuery,
-    @Query('sortDirection') sortDirection?: Prisma.SortOrder,
+      skip,
-    @Query('take', new ParseIntPipe({ optional: true })) take?: number
+      sortColumn,
+      sortDirection,
+      take
+    }: GetAssetProfilesDto
   ): Promise<AssetProfilesResponse> {
     const filters = this.apiService.buildFiltersFromQueryParams({
       filterByAssetSubClasses,

apps/api/src/app/endpoints/asset-profiles/get-asset-profiles.dto.ts

@@ -0,0 +1,61 @@
+import { SEARCH_QUERY_MAXIMUM_LENGTH } from '@ghostfolio/common/config';
+import { MarketDataPreset } from '@ghostfolio/common/types';
+
+import { Prisma } from '@prisma/client';
+import { Type } from 'class-transformer';
+import {
+  IsIn,
+  IsInt,
+  IsOptional,
+  IsString,
+  MaxLength,
+  Min
+} from 'class-validator';
+
+export class GetAssetProfilesDto {
+  @IsOptional()
+  @IsString()
+  assetSubClasses?: string;
+
+  @IsOptional()
+  @IsString()
+  dataSource?: string;
+
+  @IsIn([
+    'BENCHMARKS',
+    'CURRENCIES',
+    'ETF_WITHOUT_COUNTRIES',
+    'ETF_WITHOUT_SECTORS',
+    'NO_ACTIVITIES'
+  ] as MarketDataPreset[])
+  @IsOptional()
+  presetId?: MarketDataPreset;
+
+  @IsOptional()
+  @IsString()
+  @MaxLength(SEARCH_QUERY_MAXIMUM_LENGTH)
+  query?: string;
+
+  @IsInt()
+  @IsOptional()
+  @Min(0)
+  @Type(() => Number)
+  skip?: number;
+
+  @IsIn([
+    ...Object.values(Prisma.SymbolProfileScalarFieldEnum),
+    'activitiesCount'
+  ])
+  @IsOptional()
+  sortColumn?: string;
+
+  @IsIn(['asc', 'desc'] as Prisma.SortOrder[])
+  @IsOptional()
+  sortDirection?: Prisma.SortOrder;
+
+  @IsInt()
+  @IsOptional()
+  @Min(0)
+  @Type(() => Number)
+  take?: number;
+}