Browse Source
			
			
			Bugfix/fix issue on buy date in position detail dialog (#297)
			
				* Fix issue on buy date
* Update changelog
			
			
				pull/301/head
			
			
		 
		
			
				
					
						 Thomas Kaul
					
					4 years ago
						Thomas Kaul
					
					4 years ago
					
						
							committed by
							
								 GitHub
								GitHub
							
						 
					
				 
				
			 
		 
		
			
				
					
					No known key found for this signature in database
					
						
							GPG Key ID: 4AEE18F83AFDEB23
						
					
				
			
		
		
		
	
		
			
				 2 changed files with 
4 additions and 
3 deletions
			 
			
		 
		
			
				- 
					
					
					 
					CHANGELOG.md
				
- 
					
					
					 
					apps/api/src/app/portfolio/portfolio.service.ts
				
				
				
					
						
							
								
									
	
		
			
				
					|  |  | @ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | 
			
		
	
		
			
				
					|  |  |  | ### Fixed | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | - Fixed the node engine version mismatch in `package.json` | 
			
		
	
		
			
				
					|  |  |  | - Fixed an issue on the buy date in the position detail dialog | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ## 1.39.0 - 16.08.2021 | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
	
		
			
				
					|  |  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
			
				
					|  |  | @ -337,10 +337,10 @@ export class PortfolioService { | 
			
		
	
		
			
				
					|  |  |  |       ); | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  |       const historicalDataArray: HistoricalDataItem[] = []; | 
			
		
	
		
			
				
					|  |  |  |       let maxPrice = orders[0].unitPrice; | 
			
		
	
		
			
				
					|  |  |  |       let minPrice = orders[0].unitPrice; | 
			
		
	
		
			
				
					|  |  |  |       let maxPrice = Math.max(orders[0].unitPrice, marketPrice); | 
			
		
	
		
			
				
					|  |  |  |       let minPrice = Math.min(orders[0].unitPrice, marketPrice); | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  |       if (!historicalData[aSymbol][firstBuyDate]) { | 
			
		
	
		
			
				
					|  |  |  |       if (!historicalData?.[aSymbol]?.[firstBuyDate]) { | 
			
		
	
		
			
				
					|  |  |  |         // Add historical entry for buy date, if no historical data available
 | 
			
		
	
		
			
				
					|  |  |  |         historicalDataArray.push({ | 
			
		
	
		
			
				
					|  |  |  |           averagePrice: orders[0].unitPrice, | 
			
		
	
	
		
			
				
					|  |  | 
 |