Browse Source
			
			
			Feature/improve gui of benchmark comparator (#1334)
			
				* Improve GUI
* Update changelog
			
			
				pull/1335/head^2
			
			
		 
		
			
				
					
						 Thomas Kaul
					
					3 years ago
						Thomas Kaul
					
					3 years ago
					
						
							committed by
							
								 GitHub
								GitHub
							
						 
					
				 
				
			 
		 
		
			
				
					
					No known key found for this signature in database
					
						
							GPG Key ID: 4AEE18F83AFDEB23
						
					
				
			
		
		
		
	
		
			
				 3 changed files with 
11 additions and 
2 deletions
			 
			
		 
		
			
				- 
					
					
					 
					CHANGELOG.md
				
- 
					
					
					 
					apps/client/src/app/components/benchmark-comparator/benchmark-comparator.component.html
				
- 
					
					
					 
					apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts
				
				
				
					
						
							
								
									
	
		
			
				
					|  |  | @ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. | 
			
		
	
		
			
				
					|  |  |  | The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | 
			
		
	
		
			
				
					|  |  |  | and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ## Unreleased | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ### Changed | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | - Improved the user interface of the benchmark comparator | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ## 1.202.0 - 07.10.2022 | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  | ### Added | 
			
		
	
	
		
			
				
					|  |  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
			
				
					|  |  | @ -1,8 +1,7 @@ | 
			
		
	
		
			
				
					|  |  |  | <div class="row"> | 
			
		
	
		
			
				
					|  |  |  |   <div class="col-md-6 col-xs-12 d-flex"> | 
			
		
	
		
			
				
					|  |  |  |     <div class="align-items-center d-flex flex-grow-1 h5 mb-0 text-truncate"> | 
			
		
	
		
			
				
					|  |  |  |       <span i18n>Benchmarks</span> | 
			
		
	
		
			
				
					|  |  |  |       <sup i18n>Beta</sup> | 
			
		
	
		
			
				
					|  |  |  |       <span i18n>Performance</span> | 
			
		
	
		
			
				
					|  |  |  |       <gf-premium-indicator | 
			
		
	
		
			
				
					|  |  |  |         *ngIf="user?.subscription?.type === 'Basic'" | 
			
		
	
		
			
				
					|  |  |  |         class="ml-1" | 
			
		
	
	
		
			
				
					|  |  | @ -14,6 +13,7 @@ | 
			
		
	
		
			
				
					|  |  |  |       appearance="outline" | 
			
		
	
		
			
				
					|  |  |  |       class="w-100 without-hint" | 
			
		
	
		
			
				
					|  |  |  |       color="accent" | 
			
		
	
		
			
				
					|  |  |  |       [hidden]="benchmarks?.length === 0" | 
			
		
	
		
			
				
					|  |  |  |     > | 
			
		
	
		
			
				
					|  |  |  |       <mat-label i18n>Compare with...</mat-label> | 
			
		
	
		
			
				
					|  |  |  |       <mat-select | 
			
		
	
	
		
			
				
					|  |  | @ -21,6 +21,7 @@ | 
			
		
	
		
			
				
					|  |  |  |         [value]="benchmark" | 
			
		
	
		
			
				
					|  |  |  |         (selectionChange)="onChangeBenchmark($event.value)" | 
			
		
	
		
			
				
					|  |  |  |       > | 
			
		
	
		
			
				
					|  |  |  |         <mat-option [value]="null"></mat-option> | 
			
		
	
		
			
				
					|  |  |  |         <mat-option | 
			
		
	
		
			
				
					|  |  |  |           *ngFor="let symbolProfile of benchmarks" | 
			
		
	
		
			
				
					|  |  |  |           [value]="symbolProfile.id" | 
			
		
	
	
		
			
				
					|  |  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
			
				
					|  |  | @ -210,6 +210,8 @@ export class AnalysisPageComponent implements OnDestroy, OnInit { | 
			
		
	
		
			
				
					|  |  |  |           this.changeDetectorRef.markForCheck(); | 
			
		
	
		
			
				
					|  |  |  |         }); | 
			
		
	
		
			
				
					|  |  |  |     } else { | 
			
		
	
		
			
				
					|  |  |  |       this.benchmarkDataItems = []; | 
			
		
	
		
			
				
					|  |  |  | 
 | 
			
		
	
		
			
				
					|  |  |  |       this.isLoadingBenchmarkComparator = false; | 
			
		
	
		
			
				
					|  |  |  |     } | 
			
		
	
		
			
				
					|  |  |  |   } | 
			
		
	
	
		
			
				
					|  |  | 
 |