Browse Source
Feature/check currency in import validation (#538)
* Check currency in import validation (avoid importing transactions in wrong currency)
* Update changelog
feature/daily-exchange-rate
Thomas Kaul
3 years ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with
12 additions and
0 deletions
-
CHANGELOG.md
-
apps/api/src/app/import/import.service.ts
-
test/import/invalid-currency.csv
|
@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 |
|
|
|
|
|
|
|
|
## Unreleasd |
|
|
## Unreleasd |
|
|
|
|
|
|
|
|
|
|
|
### Added |
|
|
|
|
|
|
|
|
|
|
|
- Extended the validation in the import functionality for transactions by checking the currency of the data provider service |
|
|
|
|
|
|
|
|
### Changed |
|
|
### Changed |
|
|
|
|
|
|
|
|
- Removed the default transactions import limit |
|
|
- Removed the default transactions import limit |
|
|
|
@ -104,6 +104,12 @@ export class ImportService { |
|
|
`orders.${index}.symbol ("${symbol}") is not valid for the specified data source ("${dataSource}")` |
|
|
`orders.${index}.symbol ("${symbol}") is not valid for the specified data source ("${dataSource}")` |
|
|
); |
|
|
); |
|
|
} |
|
|
} |
|
|
|
|
|
|
|
|
|
|
|
if (result[symbol].currency !== currency) { |
|
|
|
|
|
throw new Error( |
|
|
|
|
|
`orders.${index}.currency ("${currency}") does not match with "${result[symbol].currency}"` |
|
|
|
|
|
); |
|
|
|
|
|
} |
|
|
} |
|
|
} |
|
|
} |
|
|
} |
|
|
} |
|
|
} |
|
|
|
@ -0,0 +1,2 @@ |
|
|
|
|
|
Date,Code,Currency,Price,Quantity,Action,Fee |
|
|
|
|
|
12/12/2021,BTC,EUR,44558.42,1,buy,0 |
1 |
Date |
Code |
Currency |
Price |
Quantity |
Action |
Fee |
2 |
12/12/2021 |
BTC |
EUR |
44558.42 |
1 |
buy |
0 |
|