Feature/add horizontal lines to separate delete actions in menus (#3805)

* Add horizontal lines to separate delete action

* Update changelog

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Improved the usability of various action menus by introducing horizontal lines to separate the delete action
 - Considered the user’s language in the link of the access table to share the portfolio
 - Improved the language localization for German (`de`)
 

apps/client/src/app/components/access-table/access-table.component.html

@@ -69,6 +69,7 @@
             <button mat-menu-item (click)="onCopyToClipboard(element.id)">
               <ng-container i18n>Copy link to clipboard</ng-container>
             </button>
+            <hr class="my-0" />
           }
           <button mat-menu-item (click)="onDeleteAccess(element.id)">
             <ng-container i18n>Revoke</ng-container>

apps/client/src/app/components/accounts-table/accounts-table.component.html

@@ -278,6 +278,7 @@
               <span i18n>Edit</span>
             </span>
           </button>
+          <hr class="m-0" />
           <button
             mat-menu-item
             [disabled]="element.transactionCount > 0"

apps/client/src/app/components/admin-jobs/admin-jobs.html

@@ -175,6 +175,7 @@
               <button mat-menu-item (click)="onExecuteJob(element.id)">
                 <ng-container i18n>Execute Job</ng-container>
               </button>
+              <hr class="m-0" />
               <button mat-menu-item (click)="onDeleteJob(element.id)">
                 <ng-container i18n>Delete Job</ng-container>
               </button>

apps/client/src/app/components/admin-market-data/admin-market-data.html

@@ -197,6 +197,7 @@
                 <button mat-menu-item (click)="onGatherProfileData()">
                   <ng-container i18n>Gather Profile Data</ng-container>
                 </button>
+                <hr class="m-0" />
                 <button
                   mat-menu-item
                   [disabled]="!selection.hasValue()"
@@ -230,6 +231,7 @@
                     <span i18n>Edit</span>
                   </span>
                 </a>
+                <hr class="m-0" />
                 <button
                   mat-menu-item
                   [disabled]="

apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html

@@ -44,6 +44,7 @@
       >
         <ng-container i18n>Gather Profile Data</ng-container>
       </button>
+      <hr class="m-0" />
       <button
         mat-menu-item
         type="button"

apps/client/src/app/components/admin-overview/admin-overview.html

@@ -79,6 +79,7 @@
                           </span>
                         </a>
                         @if (customCurrencies.includes(exchangeRate.label2)) {
+                          <hr class="m-0" />
                           <button
                             mat-menu-item
                             (click)="onDeleteCurrency(exchangeRate.label2)"

apps/client/src/app/components/admin-platform/admin-platform.component.html

@@ -92,6 +92,7 @@
                   <span i18n>Edit</span>
                 </span>
               </button>
+              <hr class="m-0" />
               <button
                 mat-menu-item
                 [disabled]="element.accountCount > 0"

apps/client/src/app/components/admin-tag/admin-tag.component.html

@@ -71,6 +71,7 @@
                   <span i18n>Edit</span>
                 </span>
               </button>
+              <hr class="m-0" />
               <button
                 mat-menu-item
                 [disabled]="element.activityCount > 0"

apps/client/src/app/components/admin-users/admin-users.html

@@ -218,6 +218,7 @@
                       <span i18n>Impersonate User</span>
                     </span>
                   </button>
+                  <hr class="m-0" />
                 }
                 <button
                   mat-menu-item

libs/ui/src/lib/activities-table/activities-table.component.html

@@ -55,6 +55,7 @@
           </span>
         </button>
       }
+      <hr class="m-0" />
       <button
         class="align-items-center d-flex"
         mat-menu-item
@@ -445,6 +446,7 @@
               <span i18n>Export Draft as ICS</span>
             </span>
           </button>
+          <hr class="m-0" />
           <button
             mat-menu-item
             [disabled]="!hasPermissionToDeleteActivity"