From e3662a143c2ab1407818ec51a6555b78f518b6ac Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Fri, 26 Aug 2022 20:10:59 +0200 Subject: [PATCH] Improve localization (#1191) * Improve localization * Update changelog --- CHANGELOG.md | 6 ++++++ .../portfolio/holdings/holdings-page.component.ts | 5 +++-- apps/client/src/locales/messages.de.xlf | 14 +++++++++++++- apps/client/src/locales/messages.xlf | 13 ++++++++++++- .../activities-table/activities-table.component.ts | 6 +++--- 5 files changed, 37 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 93f9abb67..ef7b7f654 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## Unreleased + +### Changed + +- Improved the language localization for German (`de`) + ## 1.183.0 - 24.08.2022 ### Added diff --git a/apps/client/src/app/pages/portfolio/holdings/holdings-page.component.ts b/apps/client/src/app/pages/portfolio/holdings/holdings-page.component.ts index 4f1708e00..4711d79f0 100644 --- a/apps/client/src/app/pages/portfolio/holdings/holdings-page.component.ts +++ b/apps/client/src/app/pages/portfolio/holdings/holdings-page.component.ts @@ -38,7 +38,6 @@ export class HoldingsPageComponent implements OnDestroy, OnInit { public routeQueryParams: Subscription; public user: User; - private readonly SEARCH_PLACEHOLDER = 'Filter by account or tag...'; private unsubscribeSubject = new Subject(); public constructor( @@ -84,7 +83,9 @@ export class HoldingsPageComponent implements OnDestroy, OnInit { this.isLoading = true; this.activeFilters = filters; this.placeholder = - this.activeFilters.length <= 0 ? this.SEARCH_PLACEHOLDER : ''; + this.activeFilters.length <= 0 + ? $localize`Filter by account or tag...` + : ''; return this.dataService.fetchPortfolioDetails({ filters: this.activeFilters diff --git a/apps/client/src/locales/messages.de.xlf b/apps/client/src/locales/messages.de.xlf index 17c3f6efd..408d9a3a7 100644 --- a/apps/client/src/locales/messages.de.xlf +++ b/apps/client/src/locales/messages.de.xlf @@ -2206,7 +2206,7 @@ Möchtest du diese Aktivität wirklich löschen? libs/ui/src/lib/activities-table/activities-table.component.ts - 136 + 134 @@ -2616,6 +2616,18 @@ apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts 136 + + apps/client/src/app/pages/portfolio/holdings/holdings-page.component.ts + 87 + + + + Filter by account, currency, symbol or type... + Filtern nach Konto, Währung, Symbol oder Typ... + + libs/ui/src/lib/activities-table/activities-table.component.ts + 291 + diff --git a/apps/client/src/locales/messages.xlf b/apps/client/src/locales/messages.xlf index dd6ee9dbc..10ab22415 100644 --- a/apps/client/src/locales/messages.xlf +++ b/apps/client/src/locales/messages.xlf @@ -1973,7 +1973,7 @@ Do you really want to delete this activity? libs/ui/src/lib/activities-table/activities-table.component.ts - 136 + 134 @@ -2329,6 +2329,10 @@ apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts 136 + + apps/client/src/app/pages/portfolio/holdings/holdings-page.component.ts + 87 + Filter by... @@ -2337,6 +2341,13 @@ 129 + + Filter by account, currency, symbol or type... + + libs/ui/src/lib/activities-table/activities-table.component.ts + 291 + + \ No newline at end of file diff --git a/libs/ui/src/lib/activities-table/activities-table.component.ts b/libs/ui/src/lib/activities-table/activities-table.component.ts index e218b3af7..0043efe1f 100644 --- a/libs/ui/src/lib/activities-table/activities-table.component.ts +++ b/libs/ui/src/lib/activities-table/activities-table.component.ts @@ -65,8 +65,6 @@ export class ActivitiesTableComponent implements OnChanges, OnDestroy { public totalFees: number; public totalValue: number; - private readonly SEARCH_PLACEHOLDER = - 'Filter by account, currency, symbol or type...'; private readonly SEARCH_STRING_SEPARATOR = ','; private unsubscribeSubject = new Subject(); @@ -289,7 +287,9 @@ export class ActivitiesTableComponent implements OnChanges, OnDestroy { }); this.placeholder = - lowercaseSearchKeywords.length <= 0 ? this.SEARCH_PLACEHOLDER : ''; + lowercaseSearchKeywords.length <= 0 + ? $localize`Filter by account, currency, symbol or type...` + : ''; this.searchKeywords = filters.map((filter) => { return filter.label;