From e487f1309d98030dde3df0668fbc8b359acf5772 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 5 Oct 2024 13:01:15 +0200 Subject: [PATCH] Switch @typescript-eslint/no-unused-expressions to error --- .eslintrc.json | 2 +- .../lib/activities-table/activities-table.component.ts | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 59b7e8b89..b8ca6a2f6 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -107,7 +107,7 @@ "@typescript-eslint/no-unsafe-argument": "warn", "@typescript-eslint/no-unsafe-assignment": "warn", "@typescript-eslint/no-unsafe-enum-comparison": "warn", - "@typescript-eslint/no-unused-expressions": "warn", + "@typescript-eslint/no-unused-expressions": "error", "@typescript-eslint/no-unsafe-member-access": "warn", "@typescript-eslint/no-unsafe-return": "warn", "@typescript-eslint/no-unused-vars": "warn", diff --git a/libs/ui/src/lib/activities-table/activities-table.component.ts b/libs/ui/src/lib/activities-table/activities-table.component.ts index 4f8fff904..67f81adce 100644 --- a/libs/ui/src/lib/activities-table/activities-table.component.ts +++ b/libs/ui/src/lib/activities-table/activities-table.component.ts @@ -269,9 +269,13 @@ export class GfActivitiesTableComponent } public toggleAllRows() { - this.areAllRowsSelected() - ? this.selectedRows.clear() - : this.dataSource.data.forEach((row) => this.selectedRows.select(row)); + if (this.areAllRowsSelected()) { + this.selectedRows.clear(); + } else { + this.dataSource.data.forEach((row) => { + this.selectedRows.select(row); + }); + } this.selectedActivities.emit(this.selectedRows.selected); }