From e50c05be73136f6812344981859747eda9979cb8 Mon Sep 17 00:00:00 2001 From: Thomas <4159106+dtslvr@users.noreply.github.com> Date: Fri, 20 Oct 2023 21:48:32 +0200 Subject: [PATCH] Refactoring --- .../import-activities-dialog.component.ts | 2 +- test/import/invalid-multi-line.csv | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts index f823c68b9..1427af92f 100644 --- a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts +++ b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts @@ -267,7 +267,7 @@ export class ImportActivitiesDialog implements OnDestroy { return; } else if (file.name.endsWith('.csv')) { - const content: string[] = fileContent.split('\n').slice(1); + const content = fileContent.split('\n').slice(1); try { const data = await this.importActivitiesService.importCsv({ diff --git a/test/import/invalid-multi-line.csv b/test/import/invalid-multi-line.csv index 6fae0bd03..ed9da3378 100644 --- a/test/import/invalid-multi-line.csv +++ b/test/import/invalid-multi-line.csv @@ -1,4 +1,5 @@ -Date,Code,Currency,Price,Quantity,Action,Fee -12/10/2023,MSFT,USD,329.050,10,buy,0 -12/10/2023,AAPL,USD,179.050,20,,0 -12/10/2023,GOOGL,USD,138.310,30,buy,0 \ No newline at end of file +Date,Code,Currency,Price,Quantity,Action,Fee,Note +16-09-2021,MSFT,USD,298.580,5,buy,19.00,My first order 🤓 +17/11/2021,MSFT,USD,0.62,5,dividend,0.00 +01.01.2022,Penthouse Apartment,USD,500000.0,1,,0.00 +20500606,MSFT,USD,0.00,0,buy,0.00