From 3824d8074021c63e9ac8af998d73ec563276348b Mon Sep 17 00:00:00 2001 From: Ronald Konjer Date: Sat, 29 Jan 2022 13:23:08 +0100 Subject: [PATCH 1/2] revert import order to original one make empty row filtering work with papaparse --- .../src/app/services/import-transactions.service.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/apps/client/src/app/services/import-transactions.service.ts b/apps/client/src/app/services/import-transactions.service.ts index 324432d9c..a9efcbb6c 100644 --- a/apps/client/src/app/services/import-transactions.service.ts +++ b/apps/client/src/app/services/import-transactions.service.ts @@ -1,8 +1,8 @@ import { HttpClient } from '@angular/common/http'; import { Injectable } from '@angular/core'; import { CreateOrderDto } from '@ghostfolio/api/app/order/create-order.dto'; -import { parse } from 'date-fns'; import { DataSource, Type } from '@prisma/client'; +import { parse } from 'date-fns'; import { parse as csvToJson } from 'papaparse'; import { isNumber } from 'lodash'; import { EMPTY } from 'rxjs'; @@ -33,14 +33,16 @@ export class ImportTransactionsService { primaryDataSource: DataSource; user: User; }) { - const content = csvToJson(fileContent, { + let content: any[] = []; + + csvToJson(fileContent, { dynamicTyping: true, header: true, skipEmptyLines: true, complete: (parsedData) => { - parsedData.data.filter((item) => item['date'] != null); + content = parsedData.data.filter((item) => item['date'] != null); } - }).data; + }); const orders: CreateOrderDto[] = []; for (const [index, item] of content.entries()) { From 184b041e7e1442d6094f66a5c61bd421602df175 Mon Sep 17 00:00:00 2001 From: Ronald Konjer Date: Sat, 29 Jan 2022 13:28:21 +0100 Subject: [PATCH 2/2] ran nx format and nx test --- .../portfolio/transactions/transactions-page.component.ts | 4 ++-- apps/client/src/app/services/import-transactions.service.ts | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/apps/client/src/app/pages/portfolio/transactions/transactions-page.component.ts b/apps/client/src/app/pages/portfolio/transactions/transactions-page.component.ts index 7ec6d9f79..a3d582cb9 100644 --- a/apps/client/src/app/pages/portfolio/transactions/transactions-page.component.ts +++ b/apps/client/src/app/pages/portfolio/transactions/transactions-page.component.ts @@ -190,7 +190,7 @@ export class TransactionsPageComponent implements OnDestroy, OnInit { try { await this.importTransactionsService.importJson({ - content: content.orders, + content: content.orders }); this.handleImportSuccess(); @@ -205,7 +205,7 @@ export class TransactionsPageComponent implements OnDestroy, OnInit { await this.importTransactionsService.importCsv({ fileContent, primaryDataSource: this.primaryDataSource, - user: this.user, + user: this.user }); this.handleImportSuccess(); diff --git a/apps/client/src/app/services/import-transactions.service.ts b/apps/client/src/app/services/import-transactions.service.ts index a9efcbb6c..4708a5779 100644 --- a/apps/client/src/app/services/import-transactions.service.ts +++ b/apps/client/src/app/services/import-transactions.service.ts @@ -59,7 +59,6 @@ export class ImportTransactionsService { }); } - await this.importJson({ content: orders }); }