Browse Source

Task/set change detection strategy to OnPush in users of admin control panel (#7266)

* Set change detection strategy to OnPush

* Update changelog
pull/7264/head
David Requeno 1 week ago
committed by GitHub
parent
commit
e9c48de490
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 1
      CHANGELOG.md
  2. 6
      apps/client/src/app/components/admin-users/admin-users.component.ts

1
CHANGELOG.md

@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- Set the change detection strategy to `OnPush` in the _FIRE_ page - Set the change detection strategy to `OnPush` in the _FIRE_ page
- Set the change detection strategy to `OnPush` in the users section of the admin control panel
- Improved the language localization for Dutch (`nl`) - Improved the language localization for Dutch (`nl`)
- Improved the language localization for French (`fr`) - Improved the language localization for French (`fr`)
- Improved the language localization for German (`de`) - Improved the language localization for German (`de`)

6
apps/client/src/app/components/admin-users/admin-users.component.ts

@ -27,6 +27,7 @@ import { GfValueComponent } from '@ghostfolio/ui/value';
import { CommonModule } from '@angular/common'; import { CommonModule } from '@angular/common';
import { import {
ChangeDetectionStrategy,
ChangeDetectorRef, ChangeDetectorRef,
Component, Component,
computed, computed,
@ -67,6 +68,7 @@ import { interval } from 'rxjs';
import { switchMap, tap } from 'rxjs/operators'; import { switchMap, tap } from 'rxjs/operators';
@Component({ @Component({
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [ imports: [
CommonModule, CommonModule,
GfPremiumIndicatorComponent, GfPremiumIndicatorComponent,
@ -165,6 +167,8 @@ export class GfAdminUsersComponent implements OnInit {
this.user.permissions, this.user.permissions,
permissions.impersonateAllUsers permissions.impersonateAllUsers
); );
this.changeDetectorRef.markForCheck();
} }
}), }),
switchMap(() => this.route.paramMap) switchMap(() => this.route.paramMap)
@ -196,6 +200,8 @@ export class GfAdminUsersComponent implements OnInit {
pageIndex: this.paginator().pageIndex, pageIndex: this.paginator().pageIndex,
showLoading: false showLoading: false
}); });
this.changeDetectorRef.markForCheck();
}); });
} }

Loading…
Cancel
Save