Browse Source

Task/reuse asset profile identifier (#7086)

Reuse AssetProfileIdentifier
pull/7084/head
Thomas Kaul 1 week ago
committed by GitHub
parent
commit
eac0a207f6
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 12
      apps/client/src/app/app.component.ts
  2. 5
      apps/client/src/app/components/admin-market-data/admin-market-data.component.ts
  3. 10
      libs/ui/src/lib/services/data.service.ts

12
apps/client/src/app/app.component.ts

@ -1,5 +1,9 @@
import { getCssVariable } from '@ghostfolio/common/helper'; import { getCssVariable } from '@ghostfolio/common/helper';
import { InfoItem, User } from '@ghostfolio/common/interfaces'; import {
AssetProfileIdentifier,
InfoItem,
User
} from '@ghostfolio/common/interfaces';
import { hasPermission, permissions } from '@ghostfolio/common/permissions'; import { hasPermission, permissions } from '@ghostfolio/common/permissions';
import { internalRoutes, publicRoutes } from '@ghostfolio/common/routes/routes'; import { internalRoutes, publicRoutes } from '@ghostfolio/common/routes/routes';
import { ColorScheme } from '@ghostfolio/common/types'; import { ColorScheme } from '@ghostfolio/common/types';
@ -27,7 +31,6 @@ import {
RouterLink, RouterLink,
RouterOutlet RouterOutlet
} from '@angular/router'; } from '@angular/router';
import { DataSource } from '@prisma/client';
import { Chart } from 'chart.js'; import { Chart } from 'chart.js';
import { addIcons } from 'ionicons'; import { addIcons } from 'ionicons';
import { openOutline } from 'ionicons/icons'; import { openOutline } from 'ionicons/icons';
@ -269,10 +272,7 @@ export class GfAppComponent implements OnInit {
private openHoldingDetailDialog({ private openHoldingDetailDialog({
dataSource, dataSource,
symbol symbol
}: { }: AssetProfileIdentifier) {
dataSource: DataSource;
symbol: string;
}) {
this.userService this.userService
.get() .get()
.pipe(takeUntilDestroyed(this.destroyRef)) .pipe(takeUntilDestroyed(this.destroyRef))

5
apps/client/src/app/components/admin-market-data/admin-market-data.component.ts

@ -408,10 +408,7 @@ export class GfAdminMarketDataComponent implements AfterViewInit, OnInit {
private openAssetProfileDialog({ private openAssetProfileDialog({
dataSource, dataSource,
symbol symbol
}: { }: AssetProfileIdentifier) {
dataSource: DataSource;
symbol: string;
}) {
this.userService this.userService
.get() .get()
.pipe(takeUntilDestroyed(this.destroyRef)) .pipe(takeUntilDestroyed(this.destroyRef))

10
libs/ui/src/lib/services/data.service.ts

@ -479,10 +479,7 @@ export class DataService {
public fetchHoldingDetail({ public fetchHoldingDetail({
dataSource, dataSource,
symbol symbol
}: { }: AssetProfileIdentifier): Observable<
dataSource: DataSource;
symbol: string;
}): Observable<
Omit<PortfolioHoldingResponse, 'dateOfFirstActivity'> & { Omit<PortfolioHoldingResponse, 'dateOfFirstActivity'> & {
dateOfFirstActivity: Date | undefined; dateOfFirstActivity: Date | undefined;
} }
@ -541,10 +538,7 @@ export class DataService {
public fetchMarketDataBySymbol({ public fetchMarketDataBySymbol({
dataSource, dataSource,
symbol symbol
}: { }: AssetProfileIdentifier): Observable<AssetProfileResponse> {
dataSource: DataSource;
symbol: string;
}): Observable<AssetProfileResponse> {
return this.http return this.http
.get<any>(`/api/v1/asset-profiles/${dataSource}/${symbol}`) .get<any>(`/api/v1/asset-profiles/${dataSource}/${symbol}`)
.pipe( .pipe(

Loading…
Cancel
Save