Refactoring

apps/api/src/app/admin/admin.controller.ts

@@ -317,9 +317,9 @@ export class AdminController {
   @Post('market-data/:dataSource/:symbol')
   @UseGuards(AuthGuard('jwt'))
   public async updateMarketData(
+    @Body() data: UpdateBulkMarketDataDto,
     @Param('dataSource') dataSource: DataSource,
-    @Param('symbol') symbol: string,
+    @Param('symbol') symbol: string
-    @Body() data: UpdateBulkMarketDataDto
   ) {
     if (
       !hasPermission(
@@ -334,11 +334,11 @@ export class AdminController {
     }
 
     const dataBulkUpdate: Prisma.MarketDataUpdateInput[] = data.marketData.map(
-      (entry) => ({
+      ({ date, marketPrice }) => ({
-        dataSource: dataSource,
+        dataSource,
-        symbol: symbol,
+        date,
-        date: entry.date,
+        marketPrice,
-        marketPrice: entry.marketPrice,
+        symbol,
         state: 'CLOSE'
       })
     );

apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts

@@ -208,11 +208,11 @@ export class AssetProfileDialog implements OnDestroy, OnInit {
     const inputSplittedByLine = inputHistoricalData.split('\n');
     const dataBulkUpdate: UpdateMarketDataDto[] = inputSplittedByLine.map(
       (line) => {
-        const inputSplittedBySeparator = line.split(';');
+        const [dateString, marketPriceString] = line.split(';');
-        const inputDate = parseISO(inputSplittedBySeparator[0]);
+
         return {
-          date: inputDate,
+          date: parseISO(dateString),
-          marketPrice: Number(inputSplittedBySeparator[1])
+          marketPrice: Number(marketPriceString)
         };
       }
     );

apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html

@@ -53,7 +53,7 @@
     ></gf-admin-market-data-detail>
 
     <div class="mt-3">
-      <mat-form-field appearance="outline" class="w-100">
+      <mat-form-field appearance="outline" class="w-100 without-hint">
         <mat-label>
           <ng-container i18n>Historical Data</ng-container> (CSV)
         </mat-label>
@@ -69,9 +69,9 @@
       </mat-form-field>
     </div>
 
-    <div class="d-flex justify-content-end" mat-dialog-actions>
+    <div class="d-flex justify-content-end mt-2">
       <button color="accent" mat-flat-button (click)="importHistoricalData()">
-        <ng-container i18n>Import historical Data </ng-container>
+        <ng-container i18n>Import Historical Data </ng-container>
       </button>
     </div>