resolve comments

apps/client/src/app/app-routing.module.ts

@@ -100,7 +100,7 @@ const routes: Routes = [
       import('./pages/open/open-page.module').then((m) => m.OpenPageModule)
   },
   {
-    path: paths.p,
+    path: paths.public,
     loadChildren: () =>
       import('./pages/public/public-page.module').then(
         (m) => m.PublicPageModule

apps/client/src/app/components/admin-settings/admin-settings.component.ts

@@ -76,8 +76,7 @@ export class AdminSettingsComponent implements OnDestroy, OnInit {
           const languageCode =
             this.user?.settings?.language ?? DEFAULT_LANGUAGE_CODE;
 
-          this.pricingUrl =
-            `https://ghostfol.io/${languageCode}/` + paths.pricing;
+          this.pricingUrl = `https://ghostfol.io/${languageCode}/${paths.pricing}`;
 
           this.changeDetectorRef.markForCheck();
         }

apps/client/src/app/core/auth.guard.ts

@@ -23,7 +23,7 @@ export class AuthGuard {
     `/${paths.features}`,
     `/${paths.markets}`,
     `/${paths.open}`,
-    `/${paths.p}`,
+    `/${paths.public}`,
     `/${paths.pricing}`,
     `/${paths.register}`,
     `/${paths.resources}`
@@ -89,13 +89,13 @@ export class AuthGuard {
             resolve(true);
             return;
           } else if (
-            state.url.startsWith('/home') &&
+            state.url.startsWith(`/${paths.home}`) &&
             user.settings.viewMode === 'ZEN'
           ) {
             this.router.navigate(['/' + paths.zen]);
             resolve(false);
             return;
-          } else if (state.url.startsWith('/start')) {
+          } else if (state.url.startsWith(`/${paths.start}`)) {
             if (user.settings.viewMode === 'ZEN') {
               this.router.navigate(['/' + paths.zen]);
             } else {
@@ -105,7 +105,7 @@ export class AuthGuard {
             resolve(false);
             return;
           } else if (
-            state.url.startsWith('/zen') &&
+            state.url.startsWith(`/${paths.zen}`) &&
             user.settings.viewMode === 'DEFAULT'
           ) {
             this.router.navigate(['/' + paths.home]);

apps/client/src/app/core/paths.ts

@@ -18,7 +18,7 @@ export const paths = {
   marketData: 'market-data',
   membership: 'membership',
   open: 'open',
-  p: 'p',
+  public: 'p',
   personalFinanceTools: 'personal-finance-tools',
   portfolio: 'portfolio',
   saas: 'saas',

apps/client/src/app/pages/faq/overview/faq-overview-page.component.ts

@@ -13,8 +13,7 @@ import { Subject, takeUntil } from 'rxjs';
   standalone: false
 })
 export class FaqOverviewPageComponent implements OnDestroy {
-  public pricingUrl =
-    `https://ghostfol.io/${document.documentElement.lang}/` + paths.pricing;
+  public pricingUrl = `https://ghostfol.io/${document.documentElement.lang}/${paths.pricing}`;
   public routerLinkFeatures = ['/' + paths.features];
   public user: User;
 

apps/client/src/app/pages/faq/saas/saas-page.component.ts

@@ -13,8 +13,7 @@ import { Subject, takeUntil } from 'rxjs';
   standalone: false
 })
 export class SaasPageComponent implements OnDestroy {
-  public pricingUrl =
-    `https://ghostfol.io/${document.documentElement.lang}/` + paths.pricing;
+  public pricingUrl = `https://ghostfol.io/${document.documentElement.lang}/${paths.pricing}`;
   public routerLinkMarkets = ['/' + paths.markets];
   public routerLinkRegister = ['/' + paths.register];
   public user: User;

apps/client/src/app/pages/faq/self-hosting/self-hosting-page.component.ts

@@ -11,8 +11,7 @@ import { Subject } from 'rxjs';
   standalone: false
 })
 export class SelfHostingPageComponent implements OnDestroy {
-  public pricingUrl =
-    `https://ghostfol.io/${document.documentElement.lang}/` + paths.pricing;
+  public pricingUrl = `https://ghostfol.io/${document.documentElement.lang}/${paths.pricing}`;
 
   private unsubscribeSubject = new Subject<void>();
 

apps/client/src/app/pages/resources/personal-finance-tools/personal-finance-tools-page-routing.module.ts

@@ -24,7 +24,7 @@ const routes: Routes = [
             return GfProductPageComponent;
           }
         ),
-      path: paths.openSourceAlternativeTo + `-${alias ?? key}`,
+      path: `${paths.openSourceAlternativeTo}-${alias ?? key}`,
       title: $localize`Open Source Alternative to ${name}`
     };
   })