Browse Source

Merge pull request #23 from dandevaud/feature/better-data-enhancing-handling

Better trackinsight inaccuracy handling
pull/5027/head
dandevaud 2 years ago
committed by GitHub
parent
commit
f039a5ef28
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 8
      apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts

8
apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts

@ -26,9 +26,7 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {
response: Partial<SymbolProfile>; response: Partial<SymbolProfile>;
symbol: string; symbol: string;
}): Promise<Partial<SymbolProfile>> { }): Promise<Partial<SymbolProfile>> {
if ( if (!(response.assetSubClass === 'ETF')) {
!(response.assetClass === 'EQUITY' && response.assetSubClass === 'ETF')
) {
return response; return response;
} }
@ -70,8 +68,8 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {
}); });
}); });
if (holdings?.weight < 0.95) { if (holdings?.weight < 1 - Math.min(holdings?.count * 0.000015, 0.95)) {
// Skip if data is inaccurate // Skip if data is inaccurate, dependent on holdings count there might be rounding issues
return response; return response;
} }

Loading…
Cancel
Save