From f1665d5a712eaab54fdfb8ca66692d6a128a88b3 Mon Sep 17 00:00:00 2001
From: KenTandrian <kenricktan11@gmail.com>
Date: Mon, 18 May 2026 23:45:45 +0700
Subject: [PATCH] fix(client): enforce encapsulation and immutability

---
 .../admin-users/admin-users.component.ts      | 38 ++++++++++---------
 1 file changed, 20 insertions(+), 18 deletions(-)

diff --git a/apps/client/src/app/components/admin-users/admin-users.component.ts b/apps/client/src/app/components/admin-users/admin-users.component.ts
index f737249ad..93899c9ee 100644
--- a/apps/client/src/app/components/admin-users/admin-users.component.ts
+++ b/apps/client/src/app/components/admin-users/admin-users.component.ts
@@ -81,19 +81,21 @@ import { switchMap, tap } from 'rxjs/operators';
   templateUrl: './admin-users.html'
 })
 export class GfAdminUsersComponent implements OnInit {
-  public dataSource = new MatTableDataSource<AdminUsersResponse['users'][0]>();
-  public defaultDateFormat: string;
-  public displayedColumns: string[] = [];
-  public getEmojiFlag = getEmojiFlag;
-  public hasPermissionForSubscription: boolean;
-  public hasPermissionToImpersonateAllUsers: boolean;
-  public info: InfoItem;
-  public isLoading = false;
-  public pageSize = DEFAULT_PAGE_SIZE;
-  public routerLinkAdminControlUsers =
+  protected dataSource = new MatTableDataSource<
+    AdminUsersResponse['users'][0]
+  >();
+  protected defaultDateFormat: string;
+  protected displayedColumns: string[] = [];
+  protected readonly getEmojiFlag = getEmojiFlag;
+  protected hasPermissionForSubscription: boolean;
+  protected hasPermissionToImpersonateAllUsers: boolean;
+  protected info: InfoItem;
+  protected isLoading = false;
+  protected readonly pageSize = DEFAULT_PAGE_SIZE;
+  protected readonly routerLinkAdminControlUsers =
     internalRoutes.adminControl.subRoutes.users.routerLink;
-  public totalItems = 0;
-  public user: User;
+  protected totalItems = 0;
+  protected user: User;
 
   private readonly deviceType = computed(
     () => this.deviceDetectorService.deviceInfo().deviceType
@@ -184,7 +186,7 @@ export class GfAdminUsersComponent implements OnInit {
     this.fetchUsers();
   }
 
-  public formatDistanceToNow(aDateString: string) {
+  protected formatDistanceToNow(aDateString: string) {
     if (aDateString) {
       const distanceString = formatDistanceToNowStrict(parseISO(aDateString), {
         addSuffix: true,
@@ -200,13 +202,13 @@ export class GfAdminUsersComponent implements OnInit {
     return '';
   }
 
-  public onChangePage(page: PageEvent) {
+  protected onChangePage(page: PageEvent) {
     this.fetchUsers({
       pageIndex: page.pageIndex
     });
   }
 
-  public onDeleteUser(aId: string) {
+  protected onDeleteUser(aId: string) {
     this.notificationService.confirm({
       confirmFn: () => {
         this.dataService
@@ -224,7 +226,7 @@ export class GfAdminUsersComponent implements OnInit {
     });
   }
 
-  public onGenerateAccessToken(aUserId: string) {
+  protected onGenerateAccessToken(aUserId: string) {
     this.notificationService.confirm({
       confirmFn: () => {
         this.dataService
@@ -249,7 +251,7 @@ export class GfAdminUsersComponent implements OnInit {
     });
   }
 
-  public onImpersonateUser(aId: string) {
+  protected onImpersonateUser(aId: string) {
     if (aId) {
       this.impersonationStorageService.setId(aId);
     } else {
@@ -259,7 +261,7 @@ export class GfAdminUsersComponent implements OnInit {
     window.location.reload();
   }
 
-  public onOpenUserDetailDialog(userId: string) {
+  protected onOpenUserDetailDialog(userId: string) {
     this.router.navigate(
       internalRoutes.adminControl.subRoutes.users.routerLink.concat(userId)
     );