From f1ede36ae9f0b96c96eb1276f16de0e93e903bf7 Mon Sep 17 00:00:00 2001
From: csehatt741 <att741@gmail.com>
Date: Sat, 5 Jul 2025 15:21:05 +0200
Subject: [PATCH] code review changes

---
 apps/client/src/app/components/header/header.component.ts | 8 ++++----
 .../pages/about/overview/about-overview-page.component.ts | 4 ++--
 .../src/app/pages/about/overview/about-overview-page.html | 2 +-
 .../pages/portfolio/x-ray/x-ray-page-routing.module.ts    | 3 +--
 .../src/app/pages/portfolio/x-ray/x-ray-page.module.ts    | 2 ++
 .../app/pages/register/register-page-routing.module.ts    | 3 +--
 .../client/src/app/pages/register/register-page.module.ts | 2 ++
 7 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/apps/client/src/app/components/header/header.component.ts b/apps/client/src/app/components/header/header.component.ts
index ef8a4f0e5..2933cf93d 100644
--- a/apps/client/src/app/components/header/header.component.ts
+++ b/apps/client/src/app/components/header/header.component.ts
@@ -36,8 +36,8 @@ import {
   menuOutline,
   optionsOutline,
   personCircleOutline,
-  radioButtonOnOutline,
-  radioButtonOffOutline
+  radioButtonOffOutline,
+  radioButtonOnOutline
 } from 'ionicons/icons';
 import { EMPTY, Subject } from 'rxjs';
 import { catchError, takeUntil } from 'rxjs/operators';
@@ -133,8 +133,8 @@ export class HeaderComponent implements OnChanges {
       menuOutline,
       optionsOutline,
       personCircleOutline,
-      radioButtonOnOutline,
-      radioButtonOffOutline
+      radioButtonOffOutline,
+      radioButtonOnOutline
     });
   }
 
diff --git a/apps/client/src/app/pages/about/overview/about-overview-page.component.ts b/apps/client/src/app/pages/about/overview/about-overview-page.component.ts
index 241174044..707b97e89 100644
--- a/apps/client/src/app/pages/about/overview/about-overview-page.component.ts
+++ b/apps/client/src/app/pages/about/overview/about-overview-page.component.ts
@@ -19,7 +19,7 @@ import { addIcons } from 'ionicons';
 import {
   logoGithub,
   logoLinkedin,
-  logoStackoverflow,
+  logoSlack,
   logoX,
   mail
 } from 'ionicons/icons';
@@ -62,7 +62,7 @@ export class AboutOverviewPageComponent implements OnDestroy, OnInit {
       permissions.enableSubscription
     );
 
-    addIcons({ logoGithub, logoLinkedin, logoStackoverflow, logoX, mail });
+    addIcons({ logoGithub, logoLinkedin, logoSlack, logoX, mail });
   }
 
   public ngOnInit() {
diff --git a/apps/client/src/app/pages/about/overview/about-overview-page.html b/apps/client/src/app/pages/about/overview/about-overview-page.html
index 9d39acb9a..9a7dd142e 100644
--- a/apps/client/src/app/pages/about/overview/about-overview-page.html
+++ b/apps/client/src/app/pages/about/overview/about-overview-page.html
@@ -81,7 +81,7 @@
             mat-icon-button
             title="Join the Ghostfolio Slack community"
           >
-            <ion-icon name="logo-stackoverflow" />
+            <ion-icon name="logo-slack" />
           </a>
           <a
             class="mx-2"
diff --git a/apps/client/src/app/pages/portfolio/x-ray/x-ray-page-routing.module.ts b/apps/client/src/app/pages/portfolio/x-ray/x-ray-page-routing.module.ts
index 155938f57..091cbc49f 100644
--- a/apps/client/src/app/pages/portfolio/x-ray/x-ray-page-routing.module.ts
+++ b/apps/client/src/app/pages/portfolio/x-ray/x-ray-page-routing.module.ts
@@ -2,7 +2,6 @@ import { AuthGuard } from '@ghostfolio/client/core/auth.guard';
 
 import { NgModule } from '@angular/core';
 import { RouterModule, Routes } from '@angular/router';
-import { IonIcon } from '@ionic/angular/standalone';
 
 import { XRayPageComponent } from './x-ray-page.component';
 
@@ -16,7 +15,7 @@ const routes: Routes = [
 ];
 
 @NgModule({
-  imports: [IonIcon, RouterModule.forChild(routes)],
+  imports: [RouterModule.forChild(routes)],
   exports: [RouterModule]
 })
 export class XRayPageRoutingModule {}
diff --git a/apps/client/src/app/pages/portfolio/x-ray/x-ray-page.module.ts b/apps/client/src/app/pages/portfolio/x-ray/x-ray-page.module.ts
index bff4f4dc9..5d16ca103 100644
--- a/apps/client/src/app/pages/portfolio/x-ray/x-ray-page.module.ts
+++ b/apps/client/src/app/pages/portfolio/x-ray/x-ray-page.module.ts
@@ -3,6 +3,7 @@ import { GfPremiumIndicatorComponent } from '@ghostfolio/ui/premium-indicator';
 
 import { CommonModule } from '@angular/common';
 import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
+import { IonIcon } from '@ionic/angular/standalone';
 import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
 
 import { XRayPageRoutingModule } from './x-ray-page-routing.module';
@@ -14,6 +15,7 @@ import { XRayPageComponent } from './x-ray-page.component';
     CommonModule,
     GfPremiumIndicatorComponent,
     GfRulesModule,
+    IonIcon,
     NgxSkeletonLoaderModule,
     XRayPageRoutingModule
   ],
diff --git a/apps/client/src/app/pages/register/register-page-routing.module.ts b/apps/client/src/app/pages/register/register-page-routing.module.ts
index d1a2ea5a0..157302999 100644
--- a/apps/client/src/app/pages/register/register-page-routing.module.ts
+++ b/apps/client/src/app/pages/register/register-page-routing.module.ts
@@ -3,7 +3,6 @@ import { publicRoutes } from '@ghostfolio/common/routes/routes';
 
 import { NgModule } from '@angular/core';
 import { RouterModule, Routes } from '@angular/router';
-import { IonIcon } from '@ionic/angular/standalone';
 
 import { RegisterPageComponent } from './register-page.component';
 
@@ -17,7 +16,7 @@ const routes: Routes = [
 ];
 
 @NgModule({
-  imports: [IonIcon, RouterModule.forChild(routes)],
+  imports: [RouterModule.forChild(routes)],
   exports: [RouterModule]
 })
 export class RegisterPageRoutingModule {}
diff --git a/apps/client/src/app/pages/register/register-page.module.ts b/apps/client/src/app/pages/register/register-page.module.ts
index b6e917e6d..5ce8e3ed9 100644
--- a/apps/client/src/app/pages/register/register-page.module.ts
+++ b/apps/client/src/app/pages/register/register-page.module.ts
@@ -4,6 +4,7 @@ import { CommonModule } from '@angular/common';
 import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
 import { MatButtonModule } from '@angular/material/button';
 import { RouterModule } from '@angular/router';
+import { IonIcon } from '@ionic/angular/standalone';
 
 import { RegisterPageRoutingModule } from './register-page-routing.module';
 import { RegisterPageComponent } from './register-page.component';
@@ -14,6 +15,7 @@ import { ShowAccessTokenDialogModule } from './show-access-token-dialog/show-acc
   imports: [
     CommonModule,
     GfLogoComponent,
+    IonIcon,
     MatButtonModule,
     RegisterPageRoutingModule,
     RouterModule,