From f2085a7e12e00c5f753cf8a758a8a199d05a615a Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 5 Apr 2025 10:23:30 +0200 Subject: [PATCH] Clean up --- apps/api/src/app/import/import.service.ts | 3 +-- apps/api/src/app/order/create-order.dto.ts | 3 --- apps/api/src/app/order/update-order.dto.ts | 4 ---- .../asset-profile-dialog/asset-profile-dialog.html | 2 +- .../create-or-update-activity-dialog.component.ts | 1 - .../import-activities-dialog.component.ts | 2 -- apps/client/src/app/services/import-activities.service.ts | 2 -- 7 files changed, 2 insertions(+), 15 deletions(-) diff --git a/apps/api/src/app/import/import.service.ts b/apps/api/src/app/import/import.service.ts index 27f513af7..7ca6833fa 100644 --- a/apps/api/src/app/import/import.service.ts +++ b/apps/api/src/app/import/import.service.ts @@ -510,7 +510,6 @@ export class ImportService { dataSource, date: dateString, fee, - isActive, quantity, symbol, type, @@ -547,7 +546,6 @@ export class ImportService { SymbolProfile: { currency, dataSource, - isActive, symbol, activitiesCount: undefined, assetClass: undefined, @@ -556,6 +554,7 @@ export class ImportService { createdAt: undefined, holdings: undefined, id: undefined, + isActive: true, sectors: undefined, updatedAt: undefined } diff --git a/apps/api/src/app/order/create-order.dto.ts b/apps/api/src/app/order/create-order.dto.ts index b8979debc..f40e65ba1 100644 --- a/apps/api/src/app/order/create-order.dto.ts +++ b/apps/api/src/app/order/create-order.dto.ts @@ -61,9 +61,6 @@ export class CreateOrderDto { @Min(0) fee: number; - @IsBoolean() - isActive: boolean; - @IsNumber() @Min(0) quantity: number; diff --git a/apps/api/src/app/order/update-order.dto.ts b/apps/api/src/app/order/update-order.dto.ts index 116b194c1..eabd1f418 100644 --- a/apps/api/src/app/order/update-order.dto.ts +++ b/apps/api/src/app/order/update-order.dto.ts @@ -11,7 +11,6 @@ import { import { Transform, TransformFnParams } from 'class-transformer'; import { IsArray, - IsBoolean, IsEnum, IsISO8601, IsNumber, @@ -63,9 +62,6 @@ export class UpdateOrderDto { @IsString() id: string; - @IsBoolean() - isActive: boolean; - @IsNumber() @Min(0) quantity: number; diff --git a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html index 00fff7a12..c58a40a51 100644 --- a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html +++ b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html @@ -520,7 +520,7 @@ [disabled]="isEditAssetProfileIdentifierMode" (change)="onToggleIsActive($event)" > - Active + Data Gathering diff --git a/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts b/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts index fb335f641..555fbc7aa 100644 --- a/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts +++ b/apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts @@ -437,7 +437,6 @@ export class CreateOrUpdateActivityDialog implements OnDestroy { date: this.activityForm.get('date').value, dataSource: this.activityForm.get('dataSource').value, fee: this.activityForm.get('fee').value, - isActive: true, quantity: this.activityForm.get('quantity').value, symbol: (['FEE', 'INTEREST', 'ITEM', 'LIABILITY'].includes( diff --git a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts index c8a443f2f..82e78a180 100644 --- a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts +++ b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts @@ -271,8 +271,6 @@ export class ImportActivitiesDialog implements OnDestroy { } content.activities = content.activities.map((activity) => { - activity.isActive = true; - if (activity.id) { delete activity.id; } diff --git a/apps/client/src/app/services/import-activities.service.ts b/apps/client/src/app/services/import-activities.service.ts index 7de9ace9b..c1b2209b3 100644 --- a/apps/client/src/app/services/import-activities.service.ts +++ b/apps/client/src/app/services/import-activities.service.ts @@ -59,7 +59,6 @@ export class ImportActivitiesService { dataSource: this.parseDataSource({ item }), date: this.parseDate({ content, index, item }), fee: this.parseFee({ content, index, item }), - isActive: true, quantity: this.parseQuantity({ content, index, item }), symbol: this.parseSymbol({ content, index, item }), type: this.parseType({ content, index, item }), @@ -139,7 +138,6 @@ export class ImportActivitiesService { accountId, comment, fee, - isActive: true, quantity, type, unitPrice,