From f28bdbd65dfdc5f58dd44f01a13df39b56f4a9b2 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 19 Sep 2026 12:26:09 +0200 Subject: [PATCH] Refactoring --- apps/api/src/app/portfolio/portfolio.service.ts | 2 +- .../rules/emergency-fund/emergency-fund-setup.ts | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts index 9ec3181889..afe5745cd8 100644 --- a/apps/api/src/app/portfolio/portfolio.service.ts +++ b/apps/api/src/app/portfolio/portfolio.service.ts @@ -1358,7 +1358,7 @@ export class PortfolioService { [ new EmergencyFundSetup({ languageCode, - emergencyFund: totalEmergencyFundInBaseCurrency, + emergencyFundInBaseCurrency: totalEmergencyFundInBaseCurrency, exchangeRateDataService: this.exchangeRateDataService, i18nService: this.i18nService }), diff --git a/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts b/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts index 6603a482df..7ed80305dc 100644 --- a/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts +++ b/apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts @@ -4,28 +4,28 @@ import { I18nService } from '@ghostfolio/api/services/i18n/i18n.service'; import { RuleSettings } from '@ghostfolio/common/interfaces'; export class EmergencyFundSetup extends Rule { - private emergencyFund: number; + private emergencyFundInBaseCurrency: number; private i18nService: I18nService; public constructor({ - emergencyFund, + emergencyFundInBaseCurrency, exchangeRateDataService, i18nService, languageCode }: { - emergencyFund: number; + emergencyFundInBaseCurrency: number; exchangeRateDataService: ExchangeRateDataService; i18nService: I18nService; languageCode: string; }) { super({ exchangeRateDataService, languageCode, key: 'EmergencyFundSetup' }); - this.emergencyFund = emergencyFund; + this.emergencyFundInBaseCurrency = emergencyFundInBaseCurrency; this.i18nService = i18nService; } public evaluate() { - if (!this.emergencyFund) { + if (!this.emergencyFundInBaseCurrency) { return { evaluation: this.i18nService.getTranslation({ id: 'rule.emergencyFundSetup.false',