Merge 6ffb7a274a into 8c80086da1

CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Added a close holding button to the holding detail dialog
 - Added the _Sponsors_ section to the about page
 - Extended the user detail dialog in the users section of the admin control panel
+- Extended the activities table menu with a _View Holding_ item
 
 ### Changed
 

libs/ui/src/lib/activities-table/activities-table.component.html

@@ -437,6 +437,14 @@
           class="no-max-width"
           xPosition="before"
         >
+          @if (canClickActivity(element)) {
+            <button mat-menu-item (click)="onClickActivity(element)">
+              <span class="align-items-center d-flex">
+                <ion-icon class="mr-2" name="wallet-outline" />
+                <span i18n>View Holding</span>
+              </span>
+            </button>
+          }
           <button mat-menu-item (click)="onUpdateActivity(element)">
             <span class="align-items-center d-flex">
               <ion-icon class="mr-2" name="create-outline" />
@@ -479,11 +487,7 @@
       *matRowDef="let row; columns: displayedColumns"
       mat-row
       [ngClass]="{
-        'cursor-pointer':
-          hasPermissionToOpenDetails &&
-          isExcludedFromAnalysis(row) === false &&
-          row.isDraft === false &&
-          ['BUY', 'DIVIDEND', 'SELL'].includes(row.type)
+        'cursor-pointer': canClickActivity(row)
       }"
       (click)="onClickActivity(row)"
     ></tr>

libs/ui/src/lib/activities-table/activities-table.component.ts

@@ -56,7 +56,8 @@ import {
   documentTextOutline,
   ellipsisHorizontal,
   ellipsisVertical,
-  trashOutline
+  trashOutline,
+  walletOutline
 } from 'ionicons/icons';
 import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
 import { Subject, Subscription, takeUntil } from 'rxjs';
@@ -153,7 +154,8 @@ export class GfActivitiesTableComponent
       documentTextOutline,
       ellipsisHorizontal,
       ellipsisVertical,
-      trashOutline
+      trashOutline,
+      walletOutline
     });
   }
 
@@ -244,12 +246,7 @@ export class GfActivitiesTableComponent
       if (!activity.error) {
         this.selectedRows.toggle(activity);
       }
-    } else if (
-      this.hasPermissionToOpenDetails &&
-      this.isExcludedFromAnalysis(activity) === false &&
-      activity.isDraft === false &&
-      ['BUY', 'DIVIDEND', 'SELL'].includes(activity.type)
-    ) {
+    } else if (this.canClickActivity(activity)) {
       this.activityClicked.emit({
         dataSource: activity.SymbolProfile.dataSource,
         symbol: activity.SymbolProfile.symbol
@@ -257,6 +254,15 @@ export class GfActivitiesTableComponent
     }
   }
 
+  public canClickActivity(activity: Activity) {
+    return (
+      this.hasPermissionToOpenDetails &&
+      this.isExcludedFromAnalysis(activity) === false &&
+      activity.isDraft === false &&
+      ['BUY', 'DIVIDEND', 'SELL'].includes(activity.type)
+    );
+  }
+
   public onCloneActivity(aActivity: OrderWithAccount) {
     this.activityToClone.emit(aActivity);
   }