Browse Source
			
			
			Bugfix/provide missing locale to rule settings dialog (#5845)
			
				* Provide locale to rule settings dialog
* Update changelog
			
			
				pull/5731/merge
			
			
		 
		
			
				
					
						 Thomas Kaul
					
					6 days ago
						Thomas Kaul
					
					6 days ago
					
						
							committed by
							
								 GitHub
								GitHub
							
						 
					
				 
				
			 
		 
		
			
				
					
					No known key found for this signature in database
					
						
							GPG Key ID: B5690EEEBB952194
						
					
				
			
		
		
		
	
		
			
				 5 changed files with 
12 additions and 
0 deletions
			 
			
		 
		
			
				- 
					
					
					 
					CHANGELOG.md
				
- 
					
					
					 
					apps/client/src/app/components/rule/rule.component.ts
				
- 
					
					
					 
					apps/client/src/app/components/rules/rules.component.html
				
- 
					
					
					 
					apps/client/src/app/components/rules/rules.component.ts
				
- 
					
					
					 
					apps/client/src/app/pages/portfolio/x-ray/x-ray-page.component.html
				
				
				
					
						
							
								
									
	
		
		
			
				
					|  | @ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. | 
			
		
	
		
		
			
				
					|  |  | The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), |  |  | The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | 
			
		
	
		
		
			
				
					|  |  | and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). |  |  | and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | 
			
		
	
		
		
			
				
					|  |  | 
 |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  |  |  |  | ## Unreleased | 
			
		
	
		
		
			
				
					|  |  |  |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  |  |  |  | ### Fixed | 
			
		
	
		
		
			
				
					|  |  |  |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  |  |  |  | - Ensured the locale is available in the settings dialog to customize the rule thresholds of the _X-ray_ page | 
			
		
	
		
		
			
				
					|  |  |  |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  | ## 2.211.0 - 2025-10-25 |  |  | ## 2.211.0 - 2025-10-25 | 
			
		
	
		
		
			
				
					|  |  | 
 |  |  | 
 | 
			
		
	
		
		
			
				
					|  |  | ### Added |  |  | ### Added | 
			
		
	
	
		
		
			
				
					|  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
		
			
				
					|  | @ -51,6 +51,7 @@ export class GfRuleComponent implements OnInit { | 
			
		
	
		
		
			
				
					|  |  |   @Input() categoryName: string; |  |  |   @Input() categoryName: string; | 
			
		
	
		
		
			
				
					|  |  |   @Input() hasPermissionToUpdateUserSettings: boolean; |  |  |   @Input() hasPermissionToUpdateUserSettings: boolean; | 
			
		
	
		
		
			
				
					|  |  |   @Input() isLoading: boolean; |  |  |   @Input() isLoading: boolean; | 
			
		
	
		
		
			
				
					|  |  |  |  |  |   @Input() locale: string; | 
			
		
	
		
		
			
				
					|  |  |   @Input() rule: PortfolioReportRule; |  |  |   @Input() rule: PortfolioReportRule; | 
			
		
	
		
		
			
				
					|  |  |   @Input() settings: XRayRulesSettings['AccountClusterRiskCurrentInvestment']; |  |  |   @Input() settings: XRayRulesSettings['AccountClusterRiskCurrentInvestment']; | 
			
		
	
		
		
			
				
					|  |  | 
 |  |  | 
 | 
			
		
	
	
		
		
			
				
					|  | @ -82,6 +83,7 @@ export class GfRuleComponent implements OnInit { | 
			
		
	
		
		
			
				
					|  |  |       data: { |  |  |       data: { | 
			
		
	
		
		
			
				
					|  |  |         rule, |  |  |         rule, | 
			
		
	
		
		
			
				
					|  |  |         categoryName: this.categoryName, |  |  |         categoryName: this.categoryName, | 
			
		
	
		
		
			
				
					|  |  |  |  |  |         locale: this.locale, | 
			
		
	
		
		
			
				
					|  |  |         settings: this.settings |  |  |         settings: this.settings | 
			
		
	
		
		
			
				
					|  |  |       } as RuleSettingsDialogParams, |  |  |       } as RuleSettingsDialogParams, | 
			
		
	
		
		
			
				
					|  |  |       width: this.deviceType === 'mobile' ? '100vw' : '50rem' |  |  |       width: this.deviceType === 'mobile' ? '100vw' : '50rem' | 
			
		
	
	
		
		
			
				
					|  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
		
			
				
					|  | @ -12,6 +12,7 @@ | 
			
		
	
		
		
			
				
					|  |  |             [hasPermissionToUpdateUserSettings]=" |  |  |             [hasPermissionToUpdateUserSettings]=" | 
			
		
	
		
		
			
				
					|  |  |               hasPermissionToUpdateUserSettings |  |  |               hasPermissionToUpdateUserSettings | 
			
		
	
		
		
			
				
					|  |  |             " |  |  |             " | 
			
		
	
		
		
			
				
					|  |  |  |  |  |             [locale]="locale" | 
			
		
	
		
		
			
				
					|  |  |             [rule]="rule" |  |  |             [rule]="rule" | 
			
		
	
		
		
			
				
					|  |  |             [settings]="settings?.[rule.key]" |  |  |             [settings]="settings?.[rule.key]" | 
			
		
	
		
		
			
				
					|  |  |             (ruleUpdated)="onRuleUpdated($event)" |  |  |             (ruleUpdated)="onRuleUpdated($event)" | 
			
		
	
	
		
		
			
				
					|  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
		
			
				
					|  | @ -26,6 +26,7 @@ export class GfRulesComponent { | 
			
		
	
		
		
			
				
					|  |  |   @Input() categoryName: string; |  |  |   @Input() categoryName: string; | 
			
		
	
		
		
			
				
					|  |  |   @Input() hasPermissionToUpdateUserSettings: boolean; |  |  |   @Input() hasPermissionToUpdateUserSettings: boolean; | 
			
		
	
		
		
			
				
					|  |  |   @Input() isLoading: boolean; |  |  |   @Input() isLoading: boolean; | 
			
		
	
		
		
			
				
					|  |  |  |  |  |   @Input() locale: string; | 
			
		
	
		
		
			
				
					|  |  |   @Input() rules: PortfolioReportRule[]; |  |  |   @Input() rules: PortfolioReportRule[]; | 
			
		
	
		
		
			
				
					|  |  |   @Input() settings: XRayRulesSettings; |  |  |   @Input() settings: XRayRulesSettings; | 
			
		
	
		
		
			
				
					|  |  | 
 |  |  | 
 | 
			
		
	
	
		
		
			
				
					|  | 
 | 
			
		
	
								
							
						
					 
					
				 
			 
		
			
			
			
			
			
			
				
				
					
						
							
								
									
	
		
		
			
				
					|  | @ -76,6 +76,7 @@ | 
			
		
	
		
		
			
				
					|  |  |               !hasImpersonationId && hasPermissionToUpdateUserSettings |  |  |               !hasImpersonationId && hasPermissionToUpdateUserSettings | 
			
		
	
		
		
			
				
					|  |  |             " |  |  |             " | 
			
		
	
		
		
			
				
					|  |  |             [isLoading]="isLoading" |  |  |             [isLoading]="isLoading" | 
			
		
	
		
		
			
				
					|  |  |  |  |  |             [locale]="user?.settings?.locale" | 
			
		
	
		
		
			
				
					|  |  |             [rules]="category.rules" |  |  |             [rules]="category.rules" | 
			
		
	
		
		
			
				
					|  |  |             [settings]="user?.settings?.xRayRules" |  |  |             [settings]="user?.settings?.xRayRules" | 
			
		
	
		
		
			
				
					|  |  |             (rulesUpdated)="onRulesUpdated($event)" |  |  |             (rulesUpdated)="onRulesUpdated($event)" | 
			
		
	
	
		
		
			
				
					|  | @ -90,6 +91,7 @@ | 
			
		
	
		
		
			
				
					|  |  |               !hasImpersonationId && hasPermissionToUpdateUserSettings |  |  |               !hasImpersonationId && hasPermissionToUpdateUserSettings | 
			
		
	
		
		
			
				
					|  |  |             " |  |  |             " | 
			
		
	
		
		
			
				
					|  |  |             [isLoading]="isLoading" |  |  |             [isLoading]="isLoading" | 
			
		
	
		
		
			
				
					|  |  |  |  |  |             [locale]="user?.settings?.locale" | 
			
		
	
		
		
			
				
					|  |  |             [rules]="inactiveRules" |  |  |             [rules]="inactiveRules" | 
			
		
	
		
		
			
				
					|  |  |             [settings]="user?.settings?.xRayRules" |  |  |             [settings]="user?.settings?.xRayRules" | 
			
		
	
		
		
			
				
					|  |  |             (rulesUpdated)="onRulesUpdated($event)" |  |  |             (rulesUpdated)="onRulesUpdated($event)" | 
			
		
	
	
		
		
			
				
					|  | 
 |