From fa39d2d2f3220905f0587d2222a88f46ec76e761 Mon Sep 17 00:00:00 2001
From: Shaunak <shaundj20@gmail.com>
Date: Sun, 16 Feb 2025 11:10:30 +0530
Subject: [PATCH] address pr comments

---
 .../asset-profile-icon.component.ts           |  1 -
 libs/ui/src/lib/assistant/assistant.html      |  6 ++---
 .../data-provider-credits.component.ts        |  1 -
 libs/ui/src/lib/value/value.component.html    | 23 +++++++++----------
 4 files changed, 13 insertions(+), 18 deletions(-)

diff --git a/apps/client/src/app/components/asset-profile-icon/asset-profile-icon.component.ts b/apps/client/src/app/components/asset-profile-icon/asset-profile-icon.component.ts
index 4e1d23a7a..179193da0 100644
--- a/apps/client/src/app/components/asset-profile-icon/asset-profile-icon.component.ts
+++ b/apps/client/src/app/components/asset-profile-icon/asset-profile-icon.component.ts
@@ -9,7 +9,6 @@ import { DataSource } from '@prisma/client';
 
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
-  imports: [],
   schemas: [CUSTOM_ELEMENTS_SCHEMA],
   selector: 'gf-asset-profile-icon',
   styleUrls: ['./asset-profile-icon.component.scss'],
diff --git a/libs/ui/src/lib/assistant/assistant.html b/libs/ui/src/lib/assistant/assistant.html
index b061d0f21..97a8000d9 100644
--- a/libs/ui/src/lib/assistant/assistant.html
+++ b/libs/ui/src/lib/assistant/assistant.html
@@ -61,8 +61,7 @@
                   width: '100%'
                 }"
               />
-            }
-            @if (!isLoading) {
+            } @else {
               <div class="px-2 py-1" i18n>No entries...</div>
             }
           }
@@ -90,8 +89,7 @@
                     width: '100%'
                   }"
                 />
-              }
-              @if (!isLoading) {
+              } @else {
                 <div class="px-2 py-1" i18n>No entries...</div>
               }
             }
diff --git a/libs/ui/src/lib/data-provider-credits/data-provider-credits.component.ts b/libs/ui/src/lib/data-provider-credits/data-provider-credits.component.ts
index 01e85fc8e..2d455c0d6 100644
--- a/libs/ui/src/lib/data-provider-credits/data-provider-credits.component.ts
+++ b/libs/ui/src/lib/data-provider-credits/data-provider-credits.component.ts
@@ -9,7 +9,6 @@ import {
 
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
-  imports: [],
   schemas: [CUSTOM_ELEMENTS_SCHEMA],
   selector: 'gf-data-provider-credits',
   styleUrls: ['./data-provider-credits.component.scss'],
diff --git a/libs/ui/src/lib/value/value.component.html b/libs/ui/src/lib/value/value.component.html
index 10a81c345..5a7d6cc76 100644
--- a/libs/ui/src/lib/value/value.component.html
+++ b/libs/ui/src/lib/value/value.component.html
@@ -33,8 +33,7 @@
               {{ formattedValue }}%
             }
           </div>
-        }
-        @if (!isPercent) {
+        } @else {
           <div
             class="mb-0 value"
             [ngClass]="{
@@ -50,14 +49,15 @@
           </div>
         }
         @if (unit && size === 'medium') {
-          <small class="ml-1">
-            {{ unit }}
-          </small>
-        }
-        @if (unit && size !== 'medium') {
-          <div class="ml-1">
-            {{ unit }}
-          </div>
+          @if (size === 'medium') {
+            <small class="ml-1">
+              {{ unit }}
+            </small>
+          } @else {
+            <div class="ml-1">
+              {{ unit }}
+            </div>
+          }
         }
       }
       @if (isString) {
@@ -95,8 +95,7 @@
           <span class="text-muted"> {{ subLabel }}</span>
         }
       </div>
-    }
-    @if (size !== 'large') {
+    } @else {
       <small class="d-block text-truncate">
         <ng-container *ngTemplateOutlet="label"></ng-container>
       </small>