From fa99876dcae84a53c6b99902b116e61e47559ae9 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sun, 8 Jun 2025 09:37:23 +0200 Subject: [PATCH] Feature/rename asset profile icon component to entity logo component (#4861) * Rename asset profile icon component to entity logo component * Update changelog --- CHANGELOG.md | 2 +- .../accounts-table/accounts-table.component.html | 8 ++++---- .../components/accounts-table/accounts-table.module.ts | 4 ++-- .../asset-profile-dialog/asset-profile-dialog.html | 2 +- .../asset-profile-dialog/asset-profile-dialog.module.ts | 4 ++-- .../admin-platform/admin-platform.component.html | 2 +- .../components/admin-platform/admin-platform.module.ts | 4 ++-- .../create-or-update-platform-dialog.html | 6 +----- .../create-or-update-platform-dialog.module.ts | 4 ++-- .../admin-settings/admin-settings.component.html | 2 +- .../components/admin-settings/admin-settings.module.ts | 4 ++-- .../create-or-update-account-dialog.html | 2 +- .../create-or-update-account-dialog.module.ts | 4 ++-- .../transfer-balance/transfer-balance-dialog.html | 4 ++-- .../transfer-balance/transfer-balance-dialog.module.ts | 4 ++-- .../create-or-update-activity-dialog.html | 2 +- .../create-or-update-activity-dialog.module.ts | 4 ++-- .../lib/activities-table/activities-table.component.html | 4 ++-- .../lib/activities-table/activities-table.component.ts | 4 ++-- libs/ui/src/lib/asset-profile-icon/index.ts | 1 - libs/ui/src/lib/assistant/assistant.component.ts | 4 ++-- libs/ui/src/lib/assistant/assistant.html | 2 +- .../entity-logo.component.html} | 0 .../entity-logo.component.scss} | 0 .../entity-logo.component.ts} | 8 ++++---- libs/ui/src/lib/entity-logo/index.ts | 1 + .../src/lib/holdings-table/holdings-table.component.html | 2 +- .../ui/src/lib/holdings-table/holdings-table.component.ts | 4 ++-- 28 files changed, 44 insertions(+), 48 deletions(-) delete mode 100644 libs/ui/src/lib/asset-profile-icon/index.ts rename libs/ui/src/lib/{asset-profile-icon/asset-profile-icon.component.html => entity-logo/entity-logo.component.html} (100%) rename libs/ui/src/lib/{asset-profile-icon/asset-profile-icon.component.scss => entity-logo/entity-logo.component.scss} (100%) rename libs/ui/src/lib/{asset-profile-icon/asset-profile-icon.component.ts => entity-logo/entity-logo.component.ts} (76%) create mode 100644 libs/ui/src/lib/entity-logo/index.ts diff --git a/CHANGELOG.md b/CHANGELOG.md index fad387eee..c2a3dca8a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed -- Moved the asset profile icon component to `@ghostfolio/ui` +- Renamed the asset profile icon component to entity logo component and moved to `@ghostfolio/ui` - Renamed `Account` to `accounts` in the `User` database schema ### Fixed diff --git a/apps/client/src/app/components/accounts-table/accounts-table.component.html b/apps/client/src/app/components/accounts-table/accounts-table.component.html index ecb51fc29..41ae74bec 100644 --- a/apps/client/src/app/components/accounts-table/accounts-table.component.html +++ b/apps/client/src/app/components/accounts-table/accounts-table.component.html @@ -44,10 +44,10 @@ @if (element.Platform?.url) { - } {{ element.name }} @@ -92,10 +92,10 @@ >
@if (element.Platform?.url) { - } {{ element.Platform?.name }} diff --git a/apps/client/src/app/components/accounts-table/accounts-table.module.ts b/apps/client/src/app/components/accounts-table/accounts-table.module.ts index da233984b..d7c6bf9fe 100644 --- a/apps/client/src/app/components/accounts-table/accounts-table.module.ts +++ b/apps/client/src/app/components/accounts-table/accounts-table.module.ts @@ -1,4 +1,4 @@ -import { GfAssetProfileIconComponent } from '@ghostfolio/ui/asset-profile-icon'; +import { GfEntityLogoComponent } from '@ghostfolio/ui/entity-logo'; import { GfValueComponent } from '@ghostfolio/ui/value'; import { CommonModule } from '@angular/common'; @@ -17,7 +17,7 @@ import { AccountsTableComponent } from './accounts-table.component'; exports: [AccountsTableComponent], imports: [ CommonModule, - GfAssetProfileIconComponent, + GfEntityLogoComponent, GfValueComponent, MatButtonModule, MatMenuModule, diff --git a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html index f10b6dc02..4c7d39fc0 100644 --- a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html +++ b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html @@ -507,7 +507,7 @@ Url @if (assetProfileForm.get('url').value) { - @if (element.url) { - @if (data.platform.url) { - + }
diff --git a/apps/client/src/app/components/admin-platform/create-or-update-platform-dialog/create-or-update-platform-dialog.module.ts b/apps/client/src/app/components/admin-platform/create-or-update-platform-dialog/create-or-update-platform-dialog.module.ts index d8b2bd128..a6239566c 100644 --- a/apps/client/src/app/components/admin-platform/create-or-update-platform-dialog/create-or-update-platform-dialog.module.ts +++ b/apps/client/src/app/components/admin-platform/create-or-update-platform-dialog/create-or-update-platform-dialog.module.ts @@ -1,4 +1,4 @@ -import { GfAssetProfileIconComponent } from '@ghostfolio/ui/asset-profile-icon'; +import { GfEntityLogoComponent } from '@ghostfolio/ui/entity-logo'; import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; @@ -14,8 +14,8 @@ import { CreateOrUpdatePlatformDialog } from './create-or-update-platform-dialog declarations: [CreateOrUpdatePlatformDialog], imports: [ CommonModule, - GfAssetProfileIconComponent, FormsModule, + GfEntityLogoComponent, MatButtonModule, MatDialogModule, MatFormFieldModule, diff --git a/apps/client/src/app/components/admin-settings/admin-settings.component.html b/apps/client/src/app/components/admin-settings/admin-settings.component.html index 2d577d582..41069fb10 100644 --- a/apps/client/src/app/components/admin-settings/admin-settings.component.html +++ b/apps/client/src/app/components/admin-settings/admin-settings.component.html @@ -9,7 +9,7 @@
- +
@if (isGhostfolioDataProvider(element)) { -
@if (account.Platform?.url) { -
@if (account.Platform?.url) { -
@if (account.Platform?.url) { - -
@if (element.Account?.Platform?.url) { -
- -