Browse Source

Bugfix/loading state of holdings table on portfolio holdings page (#7788)

* Fix loading state of holdings table

* Update changelog
pull/7779/head
Thomas Kaul 6 days ago
committed by GitHub
parent
commit
fc083fb0cd
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 1
      CHANGELOG.md
  2. 2
      apps/client/src/app/components/home-holdings/home-holdings.html
  3. 4
      libs/ui/src/lib/holdings-table/holdings-table.component.ts

1
CHANGELOG.md

@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed ### Fixed
- Fixed the loading state of the accounts table on the accounts page - Fixed the loading state of the accounts table on the accounts page
- Fixed the loading state of the holdings table on the portfolio holdings page
## 3.65.0 - 2026-08-31 ## 3.65.0 - 2026-08-31

2
apps/client/src/app/components/home-holdings/home-holdings.html

@ -37,7 +37,7 @@
} }
<div [class.d-none]="holdingsViewMode !== 'TABLE'"> <div [class.d-none]="holdingsViewMode !== 'TABLE'">
<gf-holdings-table <gf-holdings-table
[holdings]="holdings ?? []" [holdings]="holdings"
[locale]="user?.settings?.locale ?? DEFAULT_LOCALE" [locale]="user?.settings?.locale ?? DEFAULT_LOCALE"
(holdingClicked)="onHoldingClicked($event)" (holdingClicked)="onHoldingClicked($event)"
/> />

4
libs/ui/src/lib/holdings-table/holdings-table.component.ts

@ -50,7 +50,7 @@ export class GfHoldingsTableComponent {
public readonly hasPermissionToOpenDetails = input(true); public readonly hasPermissionToOpenDetails = input(true);
public readonly hasPermissionToShowQuantities = input(true); public readonly hasPermissionToShowQuantities = input(true);
public readonly hasPermissionToShowValues = input(true); public readonly hasPermissionToShowValues = input(true);
public readonly holdings = input.required<PortfolioPosition[]>(); public readonly holdings = input.required<PortfolioPosition[] | undefined>();
public readonly locale = input(getLocale()); public readonly locale = input(getLocale());
public readonly pageSize = model(Number.MAX_SAFE_INTEGER); public readonly pageSize = model(Number.MAX_SAFE_INTEGER);
@ -89,7 +89,7 @@ export class GfHoldingsTableComponent {
// Reactive data update // Reactive data update
effect(() => { effect(() => {
this.dataSource.data = this.holdings(); this.dataSource.data = this.holdings() ?? [];
}); });
// Reactive view connection // Reactive view connection

Loading…
Cancel
Save