From ff9060c9521e3e91e1e0792adaad4162b1aa6b22 Mon Sep 17 00:00:00 2001
From: Vansh <vanshparate@gmail.com>
Date: Thu, 23 Oct 2025 01:05:37 +0530
Subject: [PATCH] refator: requested changes

---
 apps/api/src/app/export/export.controller.ts                | 4 ++--
 apps/api/src/app/export/export.service.ts                   | 2 +-
 .../lib/interfaces/responses/export-response.interface.ts   | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/apps/api/src/app/export/export.controller.ts b/apps/api/src/app/export/export.controller.ts
index f00b010c4..5446f8789 100644
--- a/apps/api/src/app/export/export.controller.ts
+++ b/apps/api/src/app/export/export.controller.ts
@@ -48,8 +48,8 @@ export class ExportController {
     return this.exportService.export({
       activityIds,
       filters,
-      userSettings: this.request.user.settings.settings,
-      userId: this.request.user.id
+      userId: this.request.user.id,
+      userSettings: this.request.user.settings.settings
     });
   }
 }
diff --git a/apps/api/src/app/export/export.service.ts b/apps/api/src/app/export/export.service.ts
index 370823db3..d07b199be 100644
--- a/apps/api/src/app/export/export.service.ts
+++ b/apps/api/src/app/export/export.service.ts
@@ -40,11 +40,11 @@ export class ExportService {
 
     let { activities } = await this.orderService.getOrders({
       filters,
-      userCurrency: userSettings?.baseCurrency,
       userId,
       includeDrafts: true,
       sortColumn: 'date',
       sortDirection: 'asc',
+      userCurrency: userSettings?.baseCurrency,
       withExcludedAccountsAndActivities: true
     });
 
diff --git a/libs/common/src/lib/interfaces/responses/export-response.interface.ts b/libs/common/src/lib/interfaces/responses/export-response.interface.ts
index 91f81c0a8..8b1697ca4 100644
--- a/libs/common/src/lib/interfaces/responses/export-response.interface.ts
+++ b/libs/common/src/lib/interfaces/responses/export-response.interface.ts
@@ -7,9 +7,9 @@ import {
   Tag
 } from '@prisma/client';
 
-import { PerformanceCalculationType } from '../../types/performance-calculation-type.type';
 import { AccountBalance } from '../account-balance.interface';
 import { MarketData } from '../market-data.interface';
+import { UserSettings } from '../user-settings.interface';
 
 export interface ExportResponse {
   accounts: (Omit<Account, 'createdAt' | 'updatedAt' | 'userId'> & {
@@ -39,8 +39,8 @@ export interface ExportResponse {
   tags: Omit<Tag, 'userId'>[];
   user: {
     settings: {
-      currency: string;
-      performanceCalculationType: PerformanceCalculationType;
+      currency: UserSettings['baseCurrency'];
+      performanceCalculationType: UserSettings['performanceCalculationType'];
     };
   };
 }