ghostfolio

4180 Commits

17 Branches

644 Tags

109 MiB

Tree: 8110dd7577

Commit Graph

Author	SHA1	Message	Date
Thomas Kaul	8110dd7577	Refactoring	3 weeks ago
Sven Günther	e93b4644af	fix issue #5419 Root Causes Issue 1: Import Validation Failure - The validateActivities() method (called at apps/api/src/app/import/import.service.ts#L374) validates activities before asset profiles from the import file are created in the database (apps/api/src/app/import/import.service.ts#L245) - For MANUAL data source, ManualService.getAssetProfile() queries the database, which returns undefined for new profiles - Validation at apps/api/src/app/import/import.service.ts#L774 requires assetProfile.name to exist, causing import to fail Issue 2: Empty Name Column - Even if validation passes, the validateActivities() method only checked for the existence of the name but didn't populate it from the import data - The asset profile object used for display lacked the complete profile information from the import file Solution Modified apps/api/src/app/import/import.service.ts: 1. Pass import data to validation (apps/api/src/app/import/import.service.ts#L376) - Added assetProfilesWithMarketDataDto parameter to validateActivities() call 2. Check import data during validation (apps/api/src/app/import/import.service.ts#L755) - When asset profile doesn't exist in database (no name), check if it exists in import data - If found in import data, merge all asset profile fields (name, currency, assetClass, etc.) into the validation object - This ensures the name and other fields are available for display in the UI 3. Maintain validation rules (apps/api/src/app/import/import.service.ts#L788) - Keep existing validation that requires name for non-MANUAL BUY, DIVIDEND, and SELL activities - Separate the data population logic from validation logic	1 month ago

Author

SHA1

Message

Date

Thomas Kaul

8110dd7577

Refactoring

3 weeks ago

Sven Günther

e93b4644af

fix issue #5419

Root Causes

  Issue 1: Import Validation Failure
  - The validateActivities() method (called at apps/api/src/app/import/import.service.ts#L374) validates activities before
  asset profiles from the import file are created in the database (apps/api/src/app/import/import.service.ts#L245)
  - For MANUAL data source, ManualService.getAssetProfile() queries the database, which returns undefined for new profiles
  - Validation at apps/api/src/app/import/import.service.ts#L774 requires assetProfile.name to exist, causing import to fail

  Issue 2: Empty Name Column
  - Even if validation passes, the validateActivities() method only checked for the existence of the name but didn't populate
  it from the import data
  - The asset profile object used for display lacked the complete profile information from the import file

Solution

  Modified apps/api/src/app/import/import.service.ts:

  1. Pass import data to validation (apps/api/src/app/import/import.service.ts#L376)
    - Added assetProfilesWithMarketDataDto parameter to validateActivities() call
  2. Check import data during validation (apps/api/src/app/import/import.service.ts#L755)
    - When asset profile doesn't exist in database (no name), check if it exists in import data
    - If found in import data, merge all asset profile fields (name, currency, assetClass, etc.) into the validation object
    - This ensures the name and other fields are available for display in the UI
  3. Maintain validation rules (apps/api/src/app/import/import.service.ts#L788)
    - Keep existing validation that requires name for non-MANUAL BUY, DIVIDEND, and SELL activities
    - Separate the data population logic from validation logic

1 month ago

2 Commits (8110dd7577c92ad25a3e4bb9e636b6489518c473)