ghostfolio

Commit Graph

Author	SHA1	Message	Date
Thomas Kaul	974f6e6a1d	Refactoring	3 weeks ago
Sven Günther	0bf4e2d5bf	reformat code	4 weeks ago
Sven Günther	c8afec7319	Address PR #5670 review feedback	1 month ago
Sven Günther	e93b4644af	fix issue #5419 Root Causes Issue 1: Import Validation Failure - The validateActivities() method (called at apps/api/src/app/import/import.service.ts#L374) validates activities before asset profiles from the import file are created in the database (apps/api/src/app/import/import.service.ts#L245) - For MANUAL data source, ManualService.getAssetProfile() queries the database, which returns undefined for new profiles - Validation at apps/api/src/app/import/import.service.ts#L774 requires assetProfile.name to exist, causing import to fail Issue 2: Empty Name Column - Even if validation passes, the validateActivities() method only checked for the existence of the name but didn't populate it from the import data - The asset profile object used for display lacked the complete profile information from the import file Solution Modified apps/api/src/app/import/import.service.ts: 1. Pass import data to validation (apps/api/src/app/import/import.service.ts#L376) - Added assetProfilesWithMarketDataDto parameter to validateActivities() call 2. Check import data during validation (apps/api/src/app/import/import.service.ts#L755) - When asset profile doesn't exist in database (no name), check if it exists in import data - If found in import data, merge all asset profile fields (name, currency, assetClass, etc.) into the validation object - This ensures the name and other fields are available for display in the UI 3. Maintain validation rules (apps/api/src/app/import/import.service.ts#L788) - Keep existing validation that requires name for non-MANUAL BUY, DIVIDEND, and SELL activities - Separate the data population logic from validation logic	1 month ago
Thomas Kaul	364b2f020e	Feature/remove ITEM as order type enum (#5583 ) * Remove ITEM from Type enum * Update changelog	1 month ago
Thomas Kaul	dad3c27ad9	Feature/remove DATA_SOURCES_LEGACY (#5396 ) * Remove DATA_SOURCES_LEGACY	2 months ago
Attila Cseh	7613b54514	Feature/extend activities import by tags (#5287 ) * Extend activities import by tags * Update changelog	3 months ago
Thomas Kaul	7a5927592d	Feature/add support to exclude activity from analysis via tag (#5297 ) * Add support to exclude activity from analysis via tag * Update changelog	3 months ago
Attila Cseh	3b92558e03	Feature/extend activities import by custom asset profiles (#5243 ) * Extend activities import by custom asset profiles * Update changelog	3 months ago
Thomas Kaul	cf8eac3d44	Feature/rename Settings to settings in User database schema (#5100 ) * Rename Settings to settings in User database schema * Update changelog	4 months ago
Thomas Kaul	55e4d2fc7a	Feature/deprecate ITEM activity type in favor of BUY (#5093 ) * Deprecate ITEM activity type in favor of BUY * Update changelog	4 months ago
Thomas Kaul	7a97ec75f4	Feature/refactor portfolio service (#5063 ) * Refactor portfolio service	4 months ago
Thomas Kaul	433f1686e3	Feature/rename Account to account in Order database schema (#5052 ) * Rename Account to account in Order database schema * Update changelog	4 months ago
Thomas Kaul	738f7490f6	Feature/rename Platform to platform in Account database schema (#4999 ) * Rename Platform to platform in Account database schema * Update changelog	4 months ago
Thomas Kaul	20070d76bc	Feature/rename User to user in database schema (#4899 ) * Rename User to user in database schema * Update changelog	5 months ago
Alison Hawk	31f5c0de88	Bugfix/fix import of empty account balances (#4677 ) * Fix import of empty account balances * Update changelog --------- Co-authored-by: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>	5 months ago
Marcin Szymański	28d2fd3877	Bugfix/restore incorrect fee currency conversion (#4645 ) * Restore incorrect fee currency conversion * Update changelog	6 months ago
Thomas Kaul	3646fb7f77	Feature/refactor portfolio holding response (#4649 ) * Refactor portfolio holding response * maxPrice -> marketPriceMax * minPrice -> marketPriceMin * orders -> activities	6 months ago
Thomas Kaul	1bced96460	Feature/deprecate portfolio position endpoints (#4648 ) * Deprecate api/v1/portfolio/position endpoints * Update changelog	6 months ago
Thomas Kaul	7fb0f9b6e8	Feature/refactor import service (#4599 ) * Refactoring	6 months ago
csehatt741	3361666f63	Feature/activity in custom currency (#4486 ) * Activity in custom currency * Update changelog --------- Co-authored-by: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>	7 months ago
Tobias Kugel	57748a18ef	Feature/add data gathering toggle to asset profile details dialog (#4497 ) * Add data gathering toggle to asset profile details dialog * Update changelog	7 months ago
Marcin Szymański	5754f01819	Feature/improve check for duplicates in preview step of activities import (comments) (#4498 ) * Improve check for duplicates in preview step of activities import (comments) * Update changelog	7 months ago
Thomas Kaul	f08ed2dc68	Feature/add isActive flag to asset profile model (#4479 ) * Add isActive to SymbolProfile model * Update changelog	7 months ago
Thomas Kaul	a6952a0e37	Feature/extend get data sources in data provider service (#4473 ) * Extend data sources	8 months ago
Thomas Kaul	8f165d46e0	Feature/add cusip to asset profile model (#4347 ) * Add CUSIP * Update changelog	8 months ago
Ivan Kruglov	d5e64eaed4	Bugfix/fix issue with import of activities with type FEE (#4187 ) * Fix import of activity with type FEE * Update changelog	10 months ago
Thomas Kaul	de68841843	Feature/add user id to symbol profile database schema (#4122 ) * Add userId to SymbolProfile database schema * Update changelog	11 months ago
Thomas Kaul	5f98dfa5d6	Feature/set up Ghostfolio data provider (#4016 ) * Set up Ghostfolio data provider * Update translations * Update changelog	11 months ago
dw-0	fc5ed887ff	Feature/Set prefer-const to error in eslint configuration (#3888 ) * Set prefer-const to error in eslint configuration * Update changelog --------- Signed-off-by: Dominik Willner <th33xitus@gmail.com>	1 year ago
Thomas Kaul	403ee2741d	Feature/set up portfolio snapshot queue (#3725 ) * Set up portfolio snapshot queue * Update changelog	1 year ago
Anatoly Popov	12c722afe1	Bugfix/Use currency conversion for fees and values (#3672 ) * Use currency conversion for fees and values * Update changelog	1 year ago
Thomas Kaul	41f5801b5e	Feature/refactor unique asset type to asset profile identifier (#3636 ) * Refactoring	1 year ago
Thomas Kaul	cec55127c8	Bugix/fix dividend import from data provider for holdings without account (#3606 ) * Fix dividend import for holdings without account * Update changelog	1 year ago
Thomas Kaul	8a9ae9bb33	Feature/allocations by etf holding (#3464 ) * Setup allocations by ETF holding * Update changelog	1 year ago
Thomas Kaul	cd07802400	Bugfix/fix historical market data gathering for asset profiles with manual data source (#3336 ) * Fix historical market data gathering for asset profiles with MANUAL data source * Update changelog	2 years ago
Thomas Kaul	4e7d93db13	Feature/adapt priorities of data gathering jobs (#3262 ) * Adapt priorities of data gathering jobs * Update changelog	2 years ago
Thomas Kaul	07c0e5a612	Feature/add currency to order database schema (#3251 ) * Add currency to Order database schema * Update changelog	2 years ago
Thomas Kaul	88a9b518f6	Bugfix/fix issue with overridden names in activities table (#3200 ) * Fix issue with overridden names * Update changelog	2 years ago
Thomas Kaul	a33f8d5bed	Upgrade @types/big.js to version 6.2.2 (#3191 ) * Upgrade @types/big.js to version 6.2.2 * Refactor imports	2 years ago
Thomas Kaul	f2d431a6b8	Bugfix/improve asset profile validation in activities import (#3057 ) * Improve asset profile validation * Update changelog	2 years ago
Thomas Kaul	e921ed7f52	Reorder imports (#2988 )	2 years ago
Thomas Kaul	893e76f83f	Feature/provide data provider info in search (#2958 ) * Provide data provider info in search * Update changelog	2 years ago
Thomas Kaul	9fdbd22cb5	Bugfix/fix activities import for manual data source (#2923 ) * Fix import * Update changelog	2 years ago
Thomas Kaul	bff60ddbe0	Feature/improve asset profile validation in activities import for manual data source (#2886 ) * Improve asset profile validation for MANUAL data source * Update changelog	2 years ago
Thomas Kaul	28706d7b26	Refactor order service (#2751 )	2 years ago
Marcin Szymański	77b13b88f0	Relax check for duplicates in activities import (#2704 ) * Relax check for duplicates in activities import (allow same day) * Update changelog	2 years ago
Thomas Kaul	d155ab6f28	Feature/improve data source validation in activities import (#2645 ) * Improve data source validation * Update changelog	2 years ago
Thomas Kaul	b26aa7f51d	Feature/improve duplicate check in activities import (#2561 ) * Allow different accounts * Update changelog	2 years ago
Thomas Kaul	4e7b7375a9	Feature/setup open figi (#2526 ) * Setup OpenFIGI * Update changelog	2 years ago

1 2

86 Commits (974f6e6a1db48b78a28294e8753d6315c7118486)