ghostfolio

History

Sven Günther e93b4644af fix issue #5419 Root Causes Issue 1: Import Validation Failure - The validateActivities() method (called at apps/api/src/app/import/import.service.ts#L374) validates activities before asset profiles from the import file are created in the database (apps/api/src/app/import/import.service.ts#L245) - For MANUAL data source, ManualService.getAssetProfile() queries the database, which returns undefined for new profiles - Validation at apps/api/src/app/import/import.service.ts#L774 requires assetProfile.name to exist, causing import to fail Issue 2: Empty Name Column - Even if validation passes, the validateActivities() method only checked for the existence of the name but didn't populate it from the import data - The asset profile object used for display lacked the complete profile information from the import file Solution Modified apps/api/src/app/import/import.service.ts: 1. Pass import data to validation (apps/api/src/app/import/import.service.ts#L376) - Added assetProfilesWithMarketDataDto parameter to validateActivities() call 2. Check import data during validation (apps/api/src/app/import/import.service.ts#L755) - When asset profile doesn't exist in database (no name), check if it exists in import data - If found in import data, merge all asset profile fields (name, currency, assetClass, etc.) into the validation object - This ensures the name and other fields are available for display in the UI 3. Maintain validation rules (apps/api/src/app/import/import.service.ts#L788) - Keep existing validation that requires name for non-MANUAL BUY, DIVIDEND, and SELL activities - Separate the data population logic from validation logic		9 months ago
..
app	fix issue #5419	9 months ago
assets	Feature/add hacktoberfest 2025 blog post (#5584)	9 months ago
decorators	Reorder imports (#2988)	2 years ago
environments	Feature/add endpoint to localize site.webmanifest (#4450)	1 year ago
events	Feature/rework portfolio calculator (#3393)	2 years ago
guards	Reorder imports (#2988)	2 years ago
helper	Task/refactor imports of built-in Node.js core modules (#5513)	10 months ago
interceptors	Bugfix/add unit price in asset profile currency to redacted values (#5547)	9 months ago
middlewares	Feature/add hacktoberfest 2025 blog post (#5584)	9 months ago
models	Bugfix/handling of zero buying power in static portfolio analysis rules (#5474)	10 months ago
services	Feature/add date range query parameter to data gathering endpoint (#5684)	9 months ago
validators	Bugfix/allow GBp in currency code validation (#4640)	1 year ago
main.ts	Bugfix/fix server startup message to properly display IPv6 addresses (#5716)	9 months ago