Browse Source

Fix push device unregistration endpoint

The Bitwarden push relay expects `POST /push/delete` with a JSON body
`{"id": ...}`. The previous `POST /push/delete/{id}` returns 404 and the
status was ignored, so unregistration failed silently.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pull/7891/head
xkmtgo 3 weeks ago
parent
commit
04b7244bad
  1. 26
      src/api/push.rs

26
src/api/push.rs

@ -139,21 +139,25 @@ pub async fn unregister_push_device(push_id: Option<&PushId>) -> EmptyResult {
if !CONFIG.push_enabled() || push_id.is_none() {
return Ok(());
}
let auth_api_token = get_auth_api_token().await?;
let data = json!({
"id": push_id.as_ref().unwrap(),
});
let auth_api_token = get_auth_api_token().await?;
let auth_header = format!("Bearer {auth_api_token}");
match make_http_request(
Method::POST,
&format!("{}/push/delete/{}", CONFIG.push_relay_uri(), push_id.as_ref().unwrap()),
)?
.header(AUTHORIZATION, auth_header)
.send()
.await
if let Err(e) = make_http_request(Method::POST, &(CONFIG.push_relay_uri() + "/push/delete"))?
.header(CONTENT_TYPE, "application/json")
.header(ACCEPT, "application/json")
.header(AUTHORIZATION, auth_header)
.json(&data)
.send()
.await?
.error_for_status()
{
Ok(r) => r,
Err(e) => err!(format!("An error occurred during device unregistration: {e}")),
};
err!(format!("An error occurred during device unregistration: {e}"));
}
Ok(())
}

Loading…
Cancel
Save