Fix custom collection authorization

migrations/mysql/2026-07-16-120000_add_custom_collection_permissions/up.sql

@@ -9,3 +9,19 @@ SET create_new_collections = access_all,
     edit_any_collection = access_all,
     delete_any_collection = access_all
 WHERE atype = 4;
+
+-- A legacy Manager also managed every collection when one of their groups had access_all,
+-- even if the membership itself did not. Preserve that existing edit/delete capability without
+-- granting collection creation, which historically still required membership access_all.
+UPDATE users_organizations
+SET edit_any_collection = TRUE,
+    delete_any_collection = TRUE
+WHERE atype = 4
+  AND EXISTS (
+    SELECT 1
+    FROM groups_users
+    INNER JOIN groups ON groups.uuid = groups_users.groups_uuid
+    WHERE groups_users.users_organizations_uuid = users_organizations.uuid
+      AND groups.organizations_uuid = users_organizations.org_uuid
+      AND groups.access_all = TRUE
+  );

migrations/postgresql/2026-07-16-120000_add_custom_collection_permissions/up.sql

@@ -9,3 +9,19 @@ SET create_new_collections = access_all,
     edit_any_collection = access_all,
     delete_any_collection = access_all
 WHERE atype = 4;
+
+-- A legacy Manager also managed every collection when one of their groups had access_all,
+-- even if the membership itself did not. Preserve that existing edit/delete capability without
+-- granting collection creation, which historically still required membership access_all.
+UPDATE users_organizations
+SET edit_any_collection = TRUE,
+    delete_any_collection = TRUE
+WHERE atype = 4
+  AND EXISTS (
+    SELECT 1
+    FROM groups_users
+    INNER JOIN groups ON groups.uuid = groups_users.groups_uuid
+    WHERE groups_users.users_organizations_uuid = users_organizations.uuid
+      AND groups.organizations_uuid = users_organizations.org_uuid
+      AND groups.access_all = TRUE
+  );

migrations/sqlite/2026-07-16-120000_add_custom_collection_permissions/up.sql

@@ -9,3 +9,19 @@ SET create_new_collections = access_all,
     edit_any_collection = access_all,
     delete_any_collection = access_all
 WHERE atype = 4;
+
+-- A legacy Manager also managed every collection when one of their groups had access_all,
+-- even if the membership itself did not. Preserve that existing edit/delete capability without
+-- granting collection creation, which historically still required membership access_all.
+UPDATE users_organizations
+SET edit_any_collection = TRUE,
+    delete_any_collection = TRUE
+WHERE atype = 4
+  AND EXISTS (
+    SELECT 1
+    FROM groups_users
+    INNER JOIN groups ON groups.uuid = groups_users.groups_uuid
+    WHERE groups_users.users_organizations_uuid = users_organizations.uuid
+      AND groups.organizations_uuid = users_organizations.org_uuid
+      AND groups.access_all = TRUE
+  );

src/api/core/organizations.rs

@@ -2182,7 +2182,10 @@ async fn post_org_import(
     // any future drift fails closed with an error instead of panicking.
     for (cipher_index, col_index) in relations {
         let (Some(cipher_id), Some(col_id)) = (ciphers.get(cipher_index), collections.get(col_index)) else {
-            err!("Invalid collection relationship", "A collection relationship references a non-existent cipher or collection")
+            err!(
+                "Invalid collection relationship",
+                "A collection relationship references a non-existent cipher or collection"
+            )
         };
         CollectionCipher::save(cipher_id, col_id, &conn).await?;
     }

src/auth.rs

@@ -958,36 +958,61 @@ fn get_col_id(request: &Request<'_>) -> Option<CollectionId> {
 }
 
 #[derive(Clone, Copy, Debug, Eq, PartialEq)]
-enum CollectionDeleteAccess {
+enum CollectionManageAccess {
     Any,
-    ManagedOnly,
+    LegacyManager,
+    ExplicitManage,
     Denied,
 }
 
-fn collection_delete_access(membership: &Membership) -> CollectionDeleteAccess {
+fn collection_access_by_role(membership: &Membership, custom_has_any_access: bool) -> CollectionManageAccess {
-    if membership.can_delete_any_collection() {
+    if !membership.has_status(MembershipStatus::Confirmed) {
-        CollectionDeleteAccess::Any
+        return CollectionManageAccess::Denied;
-    } else if membership.has_status(MembershipStatus::Confirmed)
+    }
-        && (membership.has_type(MembershipType::Manager)
+
-            // A member holding the per-collection Manage grant may delete the collections they
+    match MembershipType::from_i32(membership.atype) {
-            // manage (Bitwarden's per-collection "Manage" includes deletion). This covers the
+        Some(MembershipType::Owner | MembershipType::Admin) => CollectionManageAccess::Any,
-            // legacy Manager role as well as legacy Managers that the custom-role migration
+        // Keep the pre-Custom role's broad behavior isolated to an exact legacy Manager. Its
-            // converted into all-flags-false Custom members (audit finding F-1); without it those
+        // existing helper intentionally accepts membership/group access_all.
-            // members would silently lose the ability to delete collections they still manage.
+        Some(MembershipType::Manager) => CollectionManageAccess::LegacyManager,
-            //
+        Some(MembershipType::Custom) if custom_has_any_access => CollectionManageAccess::Any,
-            // The per-collection Manage decision is made downstream by `is_coll_manageable_by_user`,
+        // A Custom member must prove an actual users_collections.manage or
-            // which also treats `access_all` as manage-everything. `edit_any_collection` is mirrored
+        // collections_groups.manage assignment. In particular, groups.access_all is not Manage.
-            // onto `access_all`, so a Custom member holding Edit any collection (or access_all) is
+        Some(MembershipType::Custom) => CollectionManageAccess::ExplicitManage,
-            // deliberately excluded here: Delete must stay independent from Edit and must never
+        Some(MembershipType::User) | None => CollectionManageAccess::Denied,
-            // become a blanket "delete any collection" without the explicit `delete_any_collection`
+    }
-            // permission handled by the `Any` branch above.
+}
-            || (membership.has_type(MembershipType::Custom)
+
-                && !membership.has_edit_any_collection()
+fn collection_edit_access(membership: &Membership) -> CollectionManageAccess {
-                && !membership.access_all))
+    collection_access_by_role(membership, membership.has_edit_any_collection())
-    {
+}
-        CollectionDeleteAccess::ManagedOnly
+
-    } else {
+fn collection_read_access(membership: &Membership) -> CollectionManageAccess {
-        CollectionDeleteAccess::Denied
+    collection_access_by_role(
+        membership,
+        membership.has_edit_any_collection() || membership.has_delete_any_collection(),
+    )
+}
+
+fn collection_delete_access(membership: &Membership) -> CollectionManageAccess {
+    collection_access_by_role(membership, membership.has_delete_any_collection())
+}
+
+async fn can_manage_collection(
+    access: CollectionManageAccess,
+    membership: &Membership,
+    collection_uuid: &CollectionId,
+    conn: &DbConn,
+) -> bool {
+    match access {
+        CollectionManageAccess::Any => true,
+        CollectionManageAccess::LegacyManager => {
+            Collection::is_coll_manageable_by_user(collection_uuid, &membership.user_uuid, conn).await
+        }
+        CollectionManageAccess::ExplicitManage => {
+            membership.has_explicit_collection_manage_access(collection_uuid, conn).await
+        }
+        CollectionManageAccess::Denied => false,
     }
 }
 
@@ -1011,14 +1036,15 @@ impl<'r> FromRequest<'r> for ManagerHeaders {
         let headers = try_outcome!(OrgHeaders::from_request(request).await);
         if headers.is_confirmed_and_manager() {
             if let Some(col_id) = get_col_id(request) {
-                let Outcome::Success(conn) = DbConn::from_request(request).await else {
+                let access = collection_edit_access(&headers.membership);
-                    err_handler!("Error getting DB")
+                if access != CollectionManageAccess::Any {
-                };
+                    let Outcome::Success(conn) = DbConn::from_request(request).await else {
-
+                        err_handler!("Error getting DB")
-                if !headers.membership.has_edit_any_collection()
+                    };
-                    && !Collection::is_coll_manageable_by_user(&col_id, &headers.membership.user_uuid, &conn).await
+
-                {
+                    if !can_manage_collection(access, &headers.membership, &col_id, &conn).await {
-                    err_handler!("The current user isn't a manager for this collection")
+                        err_handler!("The current user isn't a manager for this collection")
+                    }
                 }
             } else {
                 err_handler!("Error getting the collection id")
@@ -1062,16 +1088,14 @@ impl<'r> FromRequest<'r> for CollectionReadHeaders {
             err_handler!("Error getting the collection id")
         };
 
-        let can_read_any_collection = headers.is_confirmed_and_admin()
+        let access = collection_read_access(&headers.membership);
-            || headers.membership.has_edit_any_collection()
-            || headers.membership.has_delete_any_collection();
 
-        if !can_read_any_collection {
+        if access != CollectionManageAccess::Any {
             let Outcome::Success(conn) = DbConn::from_request(request).await else {
                 err_handler!("Error getting DB")
             };
 
-            if !Collection::is_coll_manageable_by_user(&col_id, &headers.membership.user_uuid, &conn).await {
+            if !can_manage_collection(access, &headers.membership, &col_id, &conn).await {
                 err_handler!("The current user isn't a manager for this collection")
             }
         }
@@ -1101,9 +1125,9 @@ impl From<CollectionReadHeaders> for Headers {
 /// Delete is intentionally independent from Edit any collection. Vaultwarden advertises
 /// limitCollectionDeletion=true, so deleting *any* collection requires the explicit Delete any
 /// collection permission (or Admin/Owner). Deleting an individual collection is additionally
-/// allowed for members holding the per-collection Manage grant on it — the legacy Manager role and
+/// allowed for members holding the per-collection Manage grant on it. Custom members use the
-/// the Custom members the migration produced from legacy Managers — but Edit any collection and
+/// explicit assignment only; unlike the exact legacy Manager path, membership/group access_all
-/// access_all never satisfy a delete on their own.
+/// never counts as their per-collection Manage grant.
 pub struct CollectionDeleteHeaders {
     pub host: String,
     pub device: Device,
@@ -1127,18 +1151,18 @@ impl<'r> FromRequest<'r> for CollectionDeleteHeaders {
         };
 
         match collection_delete_access(&headers.membership) {
-            CollectionDeleteAccess::Any => {}
+            CollectionManageAccess::Any => {}
-            CollectionDeleteAccess::Denied => {
+            CollectionManageAccess::Denied => {
-                // Custom is a distinct, fail-closed role. In particular, Edit any collection and
+                // Custom is a distinct, fail-closed role. Edit any collection and access_all alone
-                // access_all must not satisfy a Delete request without the explicit delete flag.
+                // must not satisfy a Delete request without either Delete any or explicit Manage.
                 err_handler!("You need the 'Delete any collection' permission to call this endpoint")
             }
-            CollectionDeleteAccess::ManagedOnly => {
+            access @ (CollectionManageAccess::LegacyManager | CollectionManageAccess::ExplicitManage) => {
                 let Outcome::Success(conn) = DbConn::from_request(request).await else {
                     err_handler!("Error getting DB")
                 };
 
-                if !Collection::is_coll_manageable_by_user(&col_id, &headers.membership.user_uuid, &conn).await {
+                if !can_manage_collection(access, &headers.membership, &col_id, &conn).await {
                     err_handler!("The current user isn't a manager for this collection")
                 }
             }
@@ -1224,7 +1248,7 @@ impl CollectionDeleteHeaders {
         conn: &DbConn,
     ) -> Result<CollectionDeleteHeaders, Error> {
         let delete_access = collection_delete_access(&h.membership);
-        if delete_access == CollectionDeleteAccess::Denied {
+        if delete_access == CollectionManageAccess::Denied {
             err!("You need the 'Delete any collection' permission to call this endpoint")
         }
 
@@ -1235,8 +1259,8 @@ impl CollectionDeleteHeaders {
             if Collection::find_by_uuid_and_org(col_id, &h.membership.org_uuid, conn).await.is_none() {
                 err!("Collection not found", "Collection does not exist or does not belong to this organization")
             }
-            if delete_access == CollectionDeleteAccess::ManagedOnly
+            if delete_access != CollectionManageAccess::Any
-                && !Collection::is_coll_manageable_by_user(col_id, &h.membership.user_uuid, conn).await
+                && !can_manage_collection(delete_access, &h.membership, col_id, conn).await
             {
                 err!("Collection not found", "The current user isn't a manager for this collection")
             }
@@ -1587,7 +1611,7 @@ pub async fn refresh_tokens(
 
 #[cfg(test)]
 mod tests {
-    use super::{CollectionDeleteAccess, collection_delete_access};
+    use super::{CollectionManageAccess, collection_delete_access, collection_edit_access, collection_read_access};
     use crate::db::models::{Membership, MembershipStatus, MembershipType};
 
     fn membership(member_type: MembershipType) -> Membership {
@@ -1598,66 +1622,68 @@ mod tests {
     }
 
     #[test]
-    fn collection_delete_permission_is_independent_from_edit_and_access_all() {
+    fn flagless_custom_requires_explicit_manage_for_edit_read_and_delete() {
-        // Edit any collection (which mirrors onto access_all) must never satisfy a delete on its
+        let custom = membership(MembershipType::Custom);
-        // own: it maps to `Denied` here, not `ManagedOnly`, so it can't ride the per-collection
+        assert_eq!(collection_edit_access(&custom), CollectionManageAccess::ExplicitManage);
-        // manage path into deleting collections. Only the explicit Delete any collection flag
+        assert_eq!(collection_read_access(&custom), CollectionManageAccess::ExplicitManage);
-        // (handled by the `Any` branch) turns Edit-any members into collection deleters.
+        assert_eq!(collection_delete_access(&custom), CollectionManageAccess::ExplicitManage);
-        let mut custom = membership(MembershipType::Custom);
+
-        custom.edit_any_collection = true;
+        // Neither a stale membership access_all value nor an external groups.access_all grant may
-        custom.access_all = true;
+        // switch a Custom member to the legacy broad helper. ExplicitManage invokes the database
-        assert_eq!(collection_delete_access(&custom), CollectionDeleteAccess::Denied);
+        // helper that only accepts users_collections.manage / collections_groups.manage.
+        let mut access_all = membership(MembershipType::Custom);
+        access_all.access_all = true;
+        assert_eq!(collection_edit_access(&access_all), CollectionManageAccess::ExplicitManage);
+        assert_eq!(collection_read_access(&access_all), CollectionManageAccess::ExplicitManage);
+        assert_eq!(collection_delete_access(&access_all), CollectionManageAccess::ExplicitManage);
+    }
 
-        custom.delete_any_collection = true;
+    #[test]
-        assert_eq!(collection_delete_access(&custom), CollectionDeleteAccess::Any);
+    fn custom_any_permissions_remain_independent() {
+        let mut edit_any = membership(MembershipType::Custom);
+        edit_any.edit_any_collection = true;
+        edit_any.access_all = true;
+        assert_eq!(collection_edit_access(&edit_any), CollectionManageAccess::Any);
+        assert_eq!(collection_read_access(&edit_any), CollectionManageAccess::Any);
+        // Edit-any alone is not blanket Delete. It still permits deletion of an explicitly managed
+        // collection, which is why the result is ExplicitManage rather than Denied.
+        assert_eq!(collection_delete_access(&edit_any), CollectionManageAccess::ExplicitManage);
 
-        custom.status = MembershipStatus::Accepted as i32;
+        let mut delete_any = membership(MembershipType::Custom);
-        assert_eq!(collection_delete_access(&custom), CollectionDeleteAccess::Denied);
+        delete_any.delete_any_collection = true;
+        assert_eq!(collection_edit_access(&delete_any), CollectionManageAccess::ExplicitManage);
+        assert_eq!(collection_read_access(&delete_any), CollectionManageAccess::Any);
+        assert_eq!(collection_delete_access(&delete_any), CollectionManageAccess::Any);
     }
 
     #[test]
-    fn collection_delete_permission_preserves_admin_and_legacy_manager_behavior() {
+    fn exact_legacy_manager_keeps_broad_helper() {
-        let admin = membership(MembershipType::Admin);
-        assert_eq!(collection_delete_access(&admin), CollectionDeleteAccess::Any);
-
         let manager = membership(MembershipType::Manager);
-        assert_eq!(collection_delete_access(&manager), CollectionDeleteAccess::ManagedOnly);
+        assert_eq!(collection_edit_access(&manager), CollectionManageAccess::LegacyManager);
+        assert_eq!(collection_read_access(&manager), CollectionManageAccess::LegacyManager);
+        assert_eq!(collection_delete_access(&manager), CollectionManageAccess::LegacyManager);
+
+        let admin = membership(MembershipType::Admin);
+        assert_eq!(collection_edit_access(&admin), CollectionManageAccess::Any);
+        assert_eq!(collection_delete_access(&admin), CollectionManageAccess::Any);
 
         let user = membership(MembershipType::User);
-        assert_eq!(collection_delete_access(&user), CollectionDeleteAccess::Denied);
+        assert_eq!(collection_edit_access(&user), CollectionManageAccess::Denied);
+        assert_eq!(collection_delete_access(&user), CollectionManageAccess::Denied);
     }
 
     #[test]
-    fn migrated_legacy_manager_retains_managed_collection_delete() {
+    fn migrated_legacy_manager_retains_explicit_collection_manage() {
-        // Regression (audit finding F-1): the custom-role migration turns every legacy Manager
+        // The role migration converts legacy Managers to flagless Custom members. They retain
-        // (including those with access_all=false and an explicit per-collection Manage grant) into a
+        // edit/delete only for collections with a persisted per-collection Manage assignment;
-        // Custom member with all collection flags false. Such a member must still reach the
+        // the restrictive helper deliberately excludes group and membership access_all.
-        // per-collection Manage check (`ManagedOnly`) instead of being denied outright, otherwise it
+        let migrated_manager = membership(MembershipType::Custom);
-        // silently loses the ability to delete the collections it manages. `ManagedOnly` is not a
+        assert_eq!(collection_edit_access(&migrated_manager), CollectionManageAccess::ExplicitManage);
-        // blanket grant: the downstream `is_coll_manageable_by_user` check still requires an actual
+        assert_eq!(collection_delete_access(&migrated_manager), CollectionManageAccess::ExplicitManage);
-        // Manage assignment (users_collections.manage / collections_groups.manage), which a plain
-        // Custom member without any assignment does not have.
-        let confirmed_custom = membership(MembershipType::Custom);
-        assert!(!confirmed_custom.access_all);
-        assert!(!confirmed_custom.edit_any_collection);
-        assert!(!confirmed_custom.delete_any_collection);
-        assert_eq!(collection_delete_access(&confirmed_custom), CollectionDeleteAccess::ManagedOnly);
-
-        // create_new_collections alone must not change the delete decision either way.
-        let mut create_only = membership(MembershipType::Custom);
-        create_only.create_new_collections = true;
-        assert_eq!(collection_delete_access(&create_only), CollectionDeleteAccess::ManagedOnly);
-
-        // Edit any collection / access_all still map to Denied (see the independence test above),
-        // so a Custom member gains a blanket delete only through delete_any_collection.
-        let mut edit_any = membership(MembershipType::Custom);
-        edit_any.edit_any_collection = true;
-        edit_any.access_all = true;
-        assert_eq!(collection_delete_access(&edit_any), CollectionDeleteAccess::Denied);
 
-        // The membership must be confirmed; an invited/accepted member is always denied.
         let mut unconfirmed = membership(MembershipType::Custom);
         unconfirmed.status = MembershipStatus::Accepted as i32;
-        assert_eq!(collection_delete_access(&unconfirmed), CollectionDeleteAccess::Denied);
+        assert_eq!(collection_edit_access(&unconfirmed), CollectionManageAccess::Denied);
+        assert_eq!(collection_delete_access(&unconfirmed), CollectionManageAccess::Denied);
     }
 }

src/db/models/organization.rs

@@ -15,8 +15,8 @@ use crate::{
     db::{
         DbConn,
         schema::{
-            ciphers, ciphers_collections, collections_groups, groups, groups_users, org_policies, organization_api_key,
+            ciphers, ciphers_collections, collections, collections_groups, groups, groups_users, org_policies,
-            organizations, users, users_collections, users_organizations,
+            organization_api_key, organizations, users, users_collections, users_organizations,
         },
     },
     error::MapResult,
@@ -119,27 +119,25 @@ impl MembershipType {
             _ => None,
         }
     }
+
+    const fn access_rank(self) -> u8 {
+        match self {
+            Self::User => 0,
+            Self::Manager | Self::Custom => 1,
+            Self::Admin => 2,
+            Self::Owner => 3,
+        }
+    }
 }
 
 impl Ord for MembershipType {
     fn cmp(&self, other: &MembershipType) -> Ordering {
-        // For easy comparison, map each variant to an access level (where 0 is lowest).
+        // Manager and Custom intentionally share the same authorization rank. A total ordering
-        // Custom is treated as a low-privilege base role (same level as Manager for
+        // still has to distinguish unequal enum variants, otherwise `Ord` would disagree with
-        // ordering purposes); its elevated capabilities are governed by the explicit
+        // `Eq` and ordered maps/sets could collapse one role into the other. The discriminant is a
-        // custom permission flags on the Membership, not by this ordering.
+        // stable tie-breaker and places Custom after Manager, preserving `Custom >= Manager` while
-        //
+        // keeping both roles below Admin.
-        // NOTE: Manager and Custom therefore share an access level while being distinct
+        self.access_rank().cmp(&other.access_rank()).then_with(|| (*self as i32).cmp(&(*other as i32)))
-        // variants: the derived `PartialEq` compares the role itself (Manager != Custom),
-        // while this ordering compares access levels (neither is greater than the other).
-        // Keep that in mind before relying on `cmp() == Equal` implying equality.
-        const ACCESS_LEVEL: [i32; 5] = [
-            3, // Owner
-            2, // Admin
-            0, // User
-            1, // Manager
-            1, // Custom
-        ];
-        ACCESS_LEVEL[*self as usize].cmp(&ACCESS_LEVEL[*other as usize])
     }
 }
 
@@ -849,6 +847,69 @@ impl Membership {
         self.has_type(MembershipType::Custom) && self.delete_any_collection
     }
 
+    /// Check for an explicit per-collection Manage grant without treating any `access_all` value
+    /// as such a grant. Custom-role collection guards use this instead of the legacy broad helper,
+    /// because membership/group `access_all` must not manufacture a per-collection Manage grant.
+    pub async fn has_explicit_collection_manage_access(&self, collection_uuid: &CollectionId, conn: &DbConn) -> bool {
+        let membership_uuid = self.uuid.clone();
+        let user_uuid = self.user_uuid.clone();
+        let org_uuid = self.org_uuid.clone();
+        let collection_uuid = collection_uuid.clone();
+
+        conn.run(move |conn| {
+            let has_direct_manage = users_organizations::table
+                .inner_join(
+                    users_collections::table.on(users_collections::user_uuid.eq(users_organizations::user_uuid)),
+                )
+                .inner_join(
+                    collections::table.on(collections::uuid
+                        .eq(users_collections::collection_uuid)
+                        .and(collections::org_uuid.eq(users_organizations::org_uuid))),
+                )
+                .filter(users_organizations::uuid.eq(membership_uuid.clone()))
+                .filter(users_organizations::user_uuid.eq(user_uuid.clone()))
+                .filter(users_organizations::org_uuid.eq(org_uuid.clone()))
+                .filter(users_organizations::status.eq(MembershipStatus::Confirmed as i32))
+                .filter(collections::uuid.eq(collection_uuid.clone()))
+                .filter(users_collections::manage.eq(true))
+                .count()
+                .first::<i64>(conn)
+                .unwrap_or(0)
+                != 0;
+
+            if has_direct_manage {
+                return true;
+            }
+
+            users_organizations::table
+                .inner_join(
+                    groups_users::table.on(groups_users::users_organizations_uuid.eq(users_organizations::uuid)),
+                )
+                .inner_join(
+                    groups::table.on(groups::uuid
+                        .eq(groups_users::groups_uuid)
+                        .and(groups::organizations_uuid.eq(users_organizations::org_uuid))),
+                )
+                .inner_join(collections_groups::table.on(collections_groups::groups_uuid.eq(groups_users::groups_uuid)))
+                .inner_join(
+                    collections::table.on(collections::uuid
+                        .eq(collections_groups::collections_uuid)
+                        .and(collections::org_uuid.eq(users_organizations::org_uuid))),
+                )
+                .filter(users_organizations::uuid.eq(membership_uuid))
+                .filter(users_organizations::user_uuid.eq(user_uuid))
+                .filter(users_organizations::org_uuid.eq(org_uuid))
+                .filter(users_organizations::status.eq(MembershipStatus::Confirmed as i32))
+                .filter(collections::uuid.eq(collection_uuid))
+                .filter(collections_groups::manage.eq(true))
+                .count()
+                .first::<i64>(conn)
+                .unwrap_or(0)
+                != 0
+        })
+        .await
+    }
+
     /// `manageAllCollections` is a client-side aggregate checkbox, not a separately persisted
     /// Bitwarden permission. It is selected exactly when all three child permissions are selected.
     pub fn has_manage_all_collections(&self) -> bool {
@@ -1347,18 +1408,32 @@ mod tests {
     }
 
     #[test]
-    #[allow(non_snake_case)]
+    fn membership_type_order_preserves_access_rank_and_ord_contract() {
-    fn partial_cmp_MembershipType() {
         assert!(MembershipType::Owner > MembershipType::Admin);
-        assert!(MembershipType::Admin > MembershipType::Manager);
+        assert!(MembershipType::Admin > MembershipType::Custom);
+        assert!(MembershipType::Custom > MembershipType::Manager);
         assert!(MembershipType::Manager > MembershipType::User);
         assert!(MembershipType::Custom == MembershipType::from_str("4").unwrap());
-        // Manager and Custom share the same access level, but are distinct roles
+
-        assert!(MembershipType::Manager != MembershipType::Custom);
+        // Permission comparisons continue to treat Custom as manager-level and below Admin.
-        assert!(MembershipType::Manager >= MembershipType::Custom);
         assert!(MembershipType::Custom >= MembershipType::Manager);
-        assert!(MembershipType::Custom > MembershipType::User);
+        let custom = MembershipType::Custom as i32;
-        assert!(MembershipType::Admin > MembershipType::Custom);
+        assert!(custom >= MembershipType::Manager);
+        assert!(custom < MembershipType::Admin);
+
+        let types = [
+            MembershipType::Owner,
+            MembershipType::Admin,
+            MembershipType::User,
+            MembershipType::Manager,
+            MembershipType::Custom,
+        ];
+        for lhs in types {
+            for rhs in types {
+                assert_eq!(lhs.cmp(&rhs) == Ordering::Equal, lhs == rhs);
+                assert_eq!(lhs.cmp(&rhs), rhs.cmp(&lhs).reverse());
+            }
+        }
     }
 
     #[test]