From 7ae89fc28bd56f4dc780ccf7a183be09e3554056 Mon Sep 17 00:00:00 2001
From: 1fexd <PGFvy85nC@protonmail.com>
Date: Sun, 5 May 2024 17:12:59 +0200
Subject: [PATCH] Check regex blacklist in internal icon resolver

---
 src/api/icons.rs | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/api/icons.rs b/src/api/icons.rs
index 94fab3f8..3afaff03 100644
--- a/src/api/icons.rs
+++ b/src/api/icons.rs
@@ -90,8 +90,12 @@ fn icon_external(domain: &str) -> Option<Redirect> {
 async fn icon_internal(domain: &str) -> Cached<(ContentType, Vec<u8>)> {
     const FALLBACK_ICON: &[u8] = include_bytes!("../static/images/fallback-icon.png");
 
-    if !is_valid_domain(domain) {
-        warn!("Invalid domain: {}", domain);
+    let is_valid = is_valid_domain(domain);
+    if !is_valid || is_domain_blacklisted(domain) {
+        if !is_valid {
+            warn!("Invalid domain: {}", domain);
+        }
+
         return Cached::ttl(
             (ContentType::new("image", "png"), FALLBACK_ICON.to_vec()),
             CONFIG.icon_cache_negttl(),