Browse Source

Check the auth request owner and state in send-email-login

pull/7918/head
Daniel García 2 weeks ago
parent
commit
bb1ff81ea0
No known key found for this signature in database GPG Key ID: FC8A7D14C3CD543A
  1. 18
      src/api/core/two_factor/email.rs

18
src/api/core/two_factor/email.rs

@ -84,18 +84,26 @@ async fn send_email_login(data: Json<SendEmailLoginData>, client_headers: Client
) )
} }
} else if let Some(auth_request_id) = auth_request_id { } else if let Some(auth_request_id) = auth_request_id {
let Some(auth_request) = AuthRequest::find_by_uuid(auth_request_id, &conn).await else {
err!("AuthRequest doesn't exist", "User not found")
};
let Some(code) = &data.auth_request_access_code else { let Some(code) = &data.auth_request_access_code else {
err!("no auth request access code") err!("no auth request access code")
}; };
let Some(auth_request) = AuthRequest::find_by_uuid_and_user(auth_request_id, &user.uuid, &conn).await
else {
err!("AuthRequest doesn't exist", "Invalid auth request or does not belong to user")
};
if auth_request.device_type != client_headers.device_type let request_expired = Utc::now().naive_utc() >= auth_request.creation_date + TimeDelta::minutes(5);
if !auth_request.approved.unwrap_or(false)
|| auth_request.authentication_date.is_some()
|| request_expired
|| auth_request.device_type != client_headers.device_type
|| auth_request.request_ip != client_headers.ip.ip.to_string() || auth_request.request_ip != client_headers.ip.ip.to_string()
|| !auth_request.check_access_code(code) || !auth_request.check_access_code(code)
{ {
err!("AuthRequest doesn't exist", "Invalid device, IP or code") err!(
"AuthRequest doesn't exist",
"Auth request not approved, already used or expired, or invalid device, IP or code"
)
} }
} else if let Some(device_identifier) = &data.device_identifier { } else if let Some(device_identifier) = &data.device_identifier {
// iOS/Android SSO logins send the email and device id but no password hash, // iOS/Android SSO logins send the email and device id but no password hash,

Loading…
Cancel
Save