From 5eae5b54790e40d1a721eac1575f682ef463fad1 Mon Sep 17 00:00:00 2001 From: Ben Letchford Date: Fri, 20 Dec 2019 10:56:48 +1100 Subject: [PATCH] Pull request feedback from @butlerx --- .github/workflows/test.yml | 4 +++- src/client/download.ts | 6 +----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 280252b..960f5a7 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,5 +1,5 @@ --- -on: [push, pull_request] +on: [pull_request] name: Run tests jobs: @@ -14,6 +14,8 @@ jobs: node-version: 12 - run: yarn name: Install dependencies + - name: ESLint checks + run: yarn lint - run: yarn build name: Compile Typescript - run: yarn test diff --git a/src/client/download.ts b/src/client/download.ts index 5050025..cf15e59 100644 --- a/src/client/download.ts +++ b/src/client/download.ts @@ -87,11 +87,7 @@ export class FileDownloader { ) { return data; } - let newData = ''; - for (let i = 0; i < data.length; i += 1) { - newData += this.bufferCharacter(data[i]); - } - return newData; + return data.split('').map(this.bufferCharacter.bind(this)).join('') } onCompleteFile(bufferCharacters: string) {