topaLE
/
Heimdall
1
0
Fork 0
Code Issues 163 Pull Requests 18 Projects Releases 47 Wiki Activity
Labels Milestones

Update FormBuilder.php #454

Open
shaohao wants to merge 1 commits from shaohao/Fix-password-issue into master
Conversation 9 Commits 1 Files Changed 1
shaohao commented 5 years ago (Migrated from github.com)
Owner

Make she the value is passed to password input.

Make she the value is passed to password input.
👍 4
farnots commented 5 years ago (Migrated from github.com)
Owner

Working great thanks 👍

Working great thanks :+1:
KrunchMuffin commented 5 years ago (Migrated from github.com)
Owner

can we get this merged?

can we get this merged?
shaohao commented 5 years ago (Migrated from github.com)
Poster
Owner

can we get this merged?

I have submiited a pull request.

> can we get this merged? I have submiited a pull request.
farnots commented 5 years ago (Migrated from github.com)
Owner

can we get this merged?

I have submiited a pull request.

This is already a pull request ...

> > can we get this merged? > > I have submiited a pull request. This is already a pull request ...
shaohao commented 5 years ago (Migrated from github.com)
Poster
Owner

can we get this merged?

I have submiited a pull request.

This is already a pull request ...

Yeah, haha...
Call the repo owner merging this. I do not have write access

> > > can we get this merged? > > > > > > I have submiited a pull request. > > This is already a pull request ... Yeah, haha... Call the repo owner merging this. I do not have write access
KodeStar commented 5 years ago (Migrated from github.com)
Owner

This is a 3rd party dependency and would need to be changed upstream - https://github.com/LaravelCollective/html/blob/6.x/src/FormBuilder.php#L334

Also it will be completely irrelevant when v3 comes out.

This is a 3rd party dependency and would need to be changed upstream - https://github.com/LaravelCollective/html/blob/6.x/src/FormBuilder.php#L334 Also it will be completely irrelevant when v3 comes out.
KrunchMuffin commented 5 years ago (Migrated from github.com)
Owner

Ahh...ok. I changed it anyway.

On Mon, Mar 16, 2020, 9:43 AM KodeStar notifications@github.com wrote:

This is a 3rd party dependency and would need to be changed upstream -
https://github.com/LaravelCollective/html/blob/6.x/src/FormBuilder.php#L334

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/linuxserver/Heimdall/pull/454#issuecomment-599543504,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH5HDLTVHTBUO3SF6BTXSTRHYUJLANCNFSM4LADL23A
.

Ahh...ok. I changed it anyway. On Mon, Mar 16, 2020, 9:43 AM KodeStar <notifications@github.com> wrote: > This is a 3rd party dependency and would need to be changed upstream - > https://github.com/LaravelCollective/html/blob/6.x/src/FormBuilder.php#L334 > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/linuxserver/Heimdall/pull/454#issuecomment-599543504>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAH5HDLTVHTBUO3SF6BTXSTRHYUJLANCNFSM4LADL23A> > . >
idolize commented 5 years ago (Migrated from github.com)
Owner

Can this be merged in the meantime since many people are still using v2?

Can this be merged in the meantime since many people are still using v2?
adripo commented 5 years ago (Migrated from github.com)
Owner

@KodeStar any news about this pull request?
When will come out v3?

@KodeStar any news about this pull request? When will come out v3?
This pull request can be merged automatically.
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug
Something isn't working duplicate
This issue or pull request already exists EnhancedApp enhancement
New feature or request FoundationApp good first issue help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested research wontfix
This will not be worked on
No Label bug duplicate EnhancedApp enhancement FoundationApp good first issue help wanted invalid question research wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'shaohao/Fix-password-issue'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes