Refactoring

apps/api/src/app/endpoints/public/public.controller.ts

@@ -57,7 +57,7 @@ export class PublicController {
     }
 
     const [
-      { holdings, markets },
+      { createdAt, holdings, markets },
       { performance: performance1d },
       { performance: performanceMax },
       { performance: performanceYtd }
@@ -81,10 +81,10 @@ export class PublicController {
     });
 
     const publicPortfolioResponse: PublicPortfolioResponse = {
+      createdAt,
       hasDetails,
       markets,
       alias: access.alias,
-      createdAt: performance1d.createdAt,
       holdings: {},
       performance: {
         '1d': {

apps/api/src/app/portfolio/portfolio.controller.ts

@@ -105,6 +105,7 @@ export class PortfolioController {
 
     const {
       accounts,
+      createdAt,
       hasErrors,
       holdings,
       markets,
@@ -233,6 +234,7 @@ export class PortfolioController {
 
     return {
       accounts,
+      createdAt,
       hasError,
       holdings,
       platforms,

apps/api/src/app/portfolio/portfolio.service.ts

@@ -376,7 +376,7 @@ export class PortfolioService {
       currency: userCurrency
     });
 
-    const { currentValueInBaseCurrency, hasErrors, positions } =
+    const { createdAt, currentValueInBaseCurrency, hasErrors, positions } =
       await portfolioCalculator.getSnapshot();
 
     const cashDetails = await this.accountService.getCashDetails({
@@ -617,6 +617,7 @@ export class PortfolioService {
 
     return {
       accounts,
+      createdAt,
       hasErrors,
       holdings,
       markets,
@@ -1100,7 +1101,6 @@ export class PortfolioService {
         firstOrderDate: undefined,
         hasErrors: false,
         performance: {
-          createdAt: new Date(),
           currentNetWorth: 0,
           currentValueInBaseCurrency: 0,
           netPerformance: 0,
@@ -1121,7 +1121,7 @@ export class PortfolioService {
       currency: userCurrency
     });
 
-    const { createdAt, errors, hasErrors, historicalData } =
+    const { errors, hasErrors, historicalData } =
       await portfolioCalculator.getSnapshot();
 
     const { endDate, startDate } = getIntervalFromDateRange(dateRange);
@@ -1155,7 +1155,6 @@ export class PortfolioService {
       hasErrors,
       firstOrderDate: parseDate(historicalData[0]?.date),
       performance: {
-        createdAt,
         netPerformance,
         netPerformanceWithCurrencyEffect,
         totalInvestment,
@@ -1811,7 +1810,7 @@ export class PortfolioService {
       }
     }
 
-    const { createdAt, currentValueInBaseCurrency, totalInvestment } =
+    const { currentValueInBaseCurrency, totalInvestment } =
       await portfolioCalculator.getSnapshot();
 
     const { performance } = await this.getPerformance({
@@ -1916,7 +1915,6 @@ export class PortfolioService {
       })?.toNumber();
 
     return {
-      createdAt,
       annualizedPerformancePercent,
       annualizedPerformancePercentWithCurrencyEffect,
       cash,

apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts

@@ -260,6 +260,7 @@ export class AllocationsPageComponent implements OnDestroy, OnInit {
     this.platforms = {};
     this.portfolioDetails = {
       accounts: {},
+      createdAt: undefined,
       holdings: {},
       platforms: {},
       summary: undefined

libs/common/src/lib/interfaces/portfolio-details.interface.ts

@@ -14,6 +14,7 @@ export interface PortfolioDetails {
       valueInPercentage?: number;
     };
   };
+  createdAt: Date;
   holdings: { [symbol: string]: PortfolioPosition };
   markets?: {
     [key in Market]: {

libs/common/src/lib/interfaces/portfolio-performance.interface.ts

@@ -1,6 +1,5 @@
 export interface PortfolioPerformance {
   annualizedPerformancePercent?: number;
-  createdAt: Date;
   currentNetWorth?: number;
   currentValueInBaseCurrency: number;
   netPerformance: number;