Browse Source

Refactoring

pull/5297/head
Thomas Kaul 3 weeks ago
parent
commit
089c27a4a8
  1. 2
      apps/api/src/app/export/export.service.ts
  2. 2
      apps/api/src/app/import/import.service.ts
  3. 4
      apps/api/src/app/order/order.controller.ts
  4. 10
      apps/api/src/app/order/order.service.ts
  5. 2
      apps/api/src/app/portfolio/portfolio.service.ts

2
apps/api/src/app/export/export.service.ts

@ -41,7 +41,7 @@ export class ExportService {
includeDrafts: true, includeDrafts: true,
sortColumn: 'date', sortColumn: 'date',
sortDirection: 'asc', sortDirection: 'asc',
withExcludedAccounts: true withExcludedAccountsAndActivities: true
}); });
if (activityIds?.length > 0) { if (activityIds?.length > 0) {

2
apps/api/src/app/import/import.service.ts

@ -533,7 +533,7 @@ export class ImportService {
userCurrency, userCurrency,
userId, userId,
includeDrafts: true, includeDrafts: true,
withExcludedAccounts: true withExcludedAccountsAndActivities: true
}); });
return activitiesDto.map( return activitiesDto.map(

4
apps/api/src/app/order/order.controller.ts

@ -144,7 +144,7 @@ export class OrderController {
skip: isNaN(skip) ? undefined : skip, skip: isNaN(skip) ? undefined : skip,
take: isNaN(take) ? undefined : take, take: isNaN(take) ? undefined : take,
userId: impersonationUserId || this.request.user.id, userId: impersonationUserId || this.request.user.id,
withExcludedAccounts: true withExcludedAccountsAndActivities: true
}); });
return { activities, count }; return { activities, count };
@ -165,7 +165,7 @@ export class OrderController {
const { activities } = await this.orderService.getOrders({ const { activities } = await this.orderService.getOrders({
userCurrency, userCurrency,
userId: impersonationUserId || this.request.user.id, userId: impersonationUserId || this.request.user.id,
withExcludedAccounts: true withExcludedAccountsAndActivities: true
}); });
const activity = activities.find((activity) => { const activity = activities.find((activity) => {

10
apps/api/src/app/order/order.service.ts

@ -276,7 +276,7 @@ export class OrderService {
userId, userId,
includeDrafts: true, includeDrafts: true,
userCurrency: undefined, userCurrency: undefined,
withExcludedAccounts: true withExcludedAccountsAndActivities: true
}); });
const { count } = await this.prismaService.order.deleteMany({ const { count } = await this.prismaService.order.deleteMany({
@ -333,7 +333,7 @@ export class OrderService {
types, types,
userCurrency, userCurrency,
userId, userId,
withExcludedAccounts = false withExcludedAccountsAndActivities = false
}: { }: {
endDate?: Date; endDate?: Date;
filters?: Filter[]; filters?: Filter[];
@ -346,7 +346,7 @@ export class OrderService {
types?: ActivityType[]; types?: ActivityType[];
userCurrency: string; userCurrency: string;
userId: string; userId: string;
withExcludedAccounts?: boolean; withExcludedAccountsAndActivities?: boolean;
}): Promise<Activities> { }): Promise<Activities> {
let orderBy: Prisma.Enumerable<Prisma.OrderOrderByWithRelationInput> = [ let orderBy: Prisma.Enumerable<Prisma.OrderOrderByWithRelationInput> = [
{ date: 'asc' }, { date: 'asc' },
@ -492,7 +492,7 @@ export class OrderService {
where.type = { in: types }; where.type = { in: types };
} }
if (withExcludedAccounts === false) { if (withExcludedAccountsAndActivities === false) {
where.OR = [ where.OR = [
{ account: null }, { account: null },
{ account: { NOT: { isExcluded: true } } } { account: { NOT: { isExcluded: true } } }
@ -617,7 +617,7 @@ export class OrderService {
filters, filters,
userCurrency, userCurrency,
userId, userId,
withExcludedAccounts: false // TODO withExcludedAccountsAndActivities: false // TODO
}); });
} }

2
apps/api/src/app/portfolio/portfolio.service.ts

@ -1800,7 +1800,7 @@ export class PortfolioService {
const { activities } = await this.orderService.getOrders({ const { activities } = await this.orderService.getOrders({
userCurrency, userCurrency,
userId, userId,
withExcludedAccounts: true withExcludedAccountsAndActivities: true
}); });
const excludedActivities: Activity[] = []; const excludedActivities: Activity[] = [];

Loading…
Cancel
Save