Browse Source

Updates based on review comments

pull/3051/head
Søren Aksel Helbo Bjergmark 2 years ago
parent
commit
10e2f8b058
  1. 9
      apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
  2. 5
      apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts

9
apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts

@ -228,13 +228,12 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {
{ name: assetProfile.summaryProfile?.sector, weight: 1 } { name: assetProfile.summaryProfile?.sector, weight: 1 }
]; ];
} }
} else if (assetSubClass == AssetSubClass.CRYPTOCURRENCY) {
response.symbol = response.symbol.replace(
new RegExp(`-${DEFAULT_CURRENCY}$`),
DEFAULT_CURRENCY
);
} }
response.symbol = this.convertFromYahooFinanceSymbol(
assetProfile.price.symbol
);
const url = assetProfile.summaryProfile?.website; const url = assetProfile.summaryProfile?.website;
if (url) { if (url) {
response.url = url; response.url = url;

5
apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts

@ -38,10 +38,7 @@ export class YahooFinanceService implements DataProviderInterface {
}: { }: {
symbol: string; symbol: string;
}): Promise<Partial<SymbolProfile>> { }): Promise<Partial<SymbolProfile>> {
const response = return await this.yahooFinanceDataEnhancerService.getAssetProfile(symbol);
await this.yahooFinanceDataEnhancerService.getAssetProfile(symbol);
return response;
} }
public getDataProviderInfo(): DataProviderInfo { public getDataProviderInfo(): DataProviderInfo {

Loading…
Cancel
Save