fix(lib): resolve type errors

libs/common/src/lib/interfaces/activities.interface.ts

@@ -8,7 +8,7 @@ export interface Activity extends Order {
   error?: ActivityError;
   feeInAssetProfileCurrency: number;
   feeInBaseCurrency: number;
-  SymbolProfile?: EnhancedSymbolProfile;
+  SymbolProfile: EnhancedSymbolProfile;
   tagIds?: string[];
   tags?: Tag[];
   unitPriceInAssetProfileCurrency: number;

libs/ui/src/lib/activities-table/activities-table.component.ts

@@ -132,7 +132,7 @@ export class GfActivitiesTableComponent
   @ViewChild(MatPaginator) paginator: MatPaginator;
   @ViewChild(MatSort) sort: MatSort;
 
-  public displayedColumns = [];
+  public displayedColumns: string[] = [];
   public endOfToday = endOfToday();
   public hasDrafts = false;
   public hasErrors = false;

libs/ui/src/lib/mocks/holdings.ts

@@ -162,7 +162,7 @@ export const holdings: PortfolioPosition[] = [
     symbol: 'bitcoin',
     tags: [],
     transactionCount: 1,
-    url: null,
+    url: undefined,
     valueInBaseCurrency: 54666.7898248
   },
   {

libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts

@@ -24,5 +24,5 @@ export class GfNoTransactionsInfoComponent {
   @HostBinding('class.has-border') @Input() hasBorder = true;
 
   public routerLinkPortfolioActivities =
-    internalRoutes.portfolio.subRoutes.activities.routerLink;
+    internalRoutes.portfolio.subRoutes?.activities.routerLink;
 }

libs/ui/src/lib/notifications/prompt-dialog/prompt-dialog.component.ts

@@ -27,11 +27,11 @@ export class GfPromptDialogComponent {
   public constructor(public dialogRef: MatDialogRef<GfPromptDialogComponent>) {}
 
   public initialize(aParams: {
-    confirmLabel?: string;
+    confirmLabel: string;
-    defaultValue?: string;
+    defaultValue: string;
-    discardLabel?: string;
+    discardLabel: string;
     title: string;
-    valueLabel?: string;
+    valueLabel: string;
   }) {
     this.confirmLabel = aParams.confirmLabel;
     this.defaultValue = aParams.defaultValue;

libs/ui/src/lib/portfolio-filter-form/portfolio-filter-form.component.ts

@@ -70,10 +70,10 @@ export class GfPortfolioFilterFormComponent
     private formBuilder: FormBuilder
   ) {
     this.filterForm = this.formBuilder.group({
-      account: new FormControl<string>(null),
+      account: new FormControl<string | null>(null),
-      assetClass: new FormControl<string>(null),
+      assetClass: new FormControl<string | null>(null),
-      holding: new FormControl<PortfolioPosition>(null),
+      holding: new FormControl<PortfolioPosition | null>(null),
-      tag: new FormControl<string>(null)
+      tag: new FormControl<string | null>(null)
     });
   }
 

libs/ui/src/lib/portfolio-proportion-chart/portfolio-proportion-chart.component.ts

@@ -135,7 +135,7 @@ export class GfPortfolioProportionChartComponent
 
             if (
               chartData[this.data[symbol][this.keys[0]].toUpperCase()]
-                .subCategory[this.data[symbol][this.keys[1]]]
+                ?.subCategory?.[this.data[symbol][this.keys[1]]]
             ) {
               chartData[
                 this.data[symbol][this.keys[0]].toUpperCase()

libs/ui/src/lib/services/admin.service.ts

@@ -132,7 +132,7 @@ export class AdminService {
   public fetchJobs({ status }: { status?: JobStatus[] }) {
     let params = new HttpParams();
 
-    if (status?.length > 0) {
+    if (status && status.length > 0) {
       params = params.append('status', status.join(','));
     }
 
@@ -158,8 +158,8 @@ export class AdminService {
   }) {
     let params = new HttpParams();
 
-    params = params.append('skip', skip);
+    if (skip) params = params.append('skip', skip);
-    params = params.append('take', take);
+    if (take) params = params.append('take', take);
 
     return this.http.get<AdminUsersResponse>('/api/v1/admin/user', { params });
   }

libs/ui/src/lib/services/data.service.ts

@@ -89,7 +89,7 @@ export class DataService {
   public buildFiltersAsQueryParams({ filters }: { filters?: Filter[] }) {
     let params = new HttpParams();
 
-    if (filters?.length > 0) {
+    if (filters && filters.length > 0) {
       const {
         ACCOUNT: filtersByAccount,
         ASSET_CLASS: filtersByAssetClass,

libs/ui/src/lib/shared/abstract-mat-form-field.ts

@@ -137,7 +137,7 @@ export abstract class AbstractMatFormField<T>
 
   public ngDoCheck() {
     if (this.ngControl) {
-      this.errorState = this.ngControl.invalid && this.ngControl.touched;
+      this.errorState = !!(this.ngControl.invalid && this.ngControl.touched);
       this.stateChanges.next();
     }
   }