Browse Source

code review changes

pull/5221/head
Attila Cseh 1 month ago
parent
commit
1f3ffdd2d6
  1. 7
      CHANGELOG.md
  2. 4
      apps/client/src/app/app.component.ts
  3. 1
      libs/ui/.storybook/main.js
  4. 4
      libs/ui/eslint.config.cjs
  5. 6
      libs/ui/src/lib/currency-selector/currency-selector.component.ts
  6. 6
      libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts

7
CHANGELOG.md

@ -22,7 +22,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved the language localization for German (`de`) - Improved the language localization for German (`de`)
- Improved the language localization for Spanish (`es`) - Improved the language localization for Spanish (`es`)
- Upgraded `countries-and-timezones` from version `3.7.2` to `3.8.0` - Upgraded `countries-and-timezones` from version `3.7.2` to `3.8.0`
- Upgraded `Nx` from version `21.1.2` to `21.2.4` - Upgraded `nx` from version `21.1.2` to `21.2.4`
- Upgraded `angular` from version `19.2.1` to `20.0.7`
- Upgraded `ngx-device-detector` from version `9.0.0` to `10.0.2`
- Upgraded `ngx-markdown` from version `19.0.0` to `20.0.0`
- Upgraded `ngx-stripe` from version `19.7.0` to `20.7.0`
- Upgraded `storybook` from version `8.6.12` to `9.0.17`
## 2.183.0 - 2025-07-20 ## 2.183.0 - 2025-07-20

4
apps/client/src/app/app.component.ts

@ -10,11 +10,11 @@ import {
ChangeDetectionStrategy, ChangeDetectionStrategy,
ChangeDetectorRef, ChangeDetectorRef,
Component, Component,
DOCUMENT,
HostBinding, HostBinding,
Inject, Inject,
OnDestroy, OnDestroy,
OnInit, OnInit
DOCUMENT
} from '@angular/core'; } from '@angular/core';
import { MatDialog } from '@angular/material/dialog'; import { MatDialog } from '@angular/material/dialog';
import { Title } from '@angular/platform-browser'; import { Title } from '@angular/platform-browser';

1
libs/ui/.storybook/main.js

@ -2,6 +2,7 @@ import { createRequire } from 'node:module';
import { dirname, join } from 'node:path'; import { dirname, join } from 'node:path';
const require = createRequire(import.meta.url); const require = createRequire(import.meta.url);
/** @type {import('@storybook/angular').StorybookConfig} */ /** @type {import('@storybook/angular').StorybookConfig} */
const config = { const config = {
addons: [getAbsolutePath('@storybook/addon-docs')], addons: [getAbsolutePath('@storybook/addon-docs')],

4
libs/ui/eslint.config.cjs

@ -40,8 +40,8 @@ module.exports = [
style: 'kebab-case' style: 'kebab-case'
} }
], ],
'@angular-eslint/prefer-standalone': 'off', '@angular-eslint/prefer-inject': 'off',
'@angular-eslint/prefer-inject': 'off' '@angular-eslint/prefer-standalone': 'off'
}, },
languageOptions: { languageOptions: {
parserOptions: { parserOptions: {

6
libs/ui/src/lib/currency-selector/currency-selector.component.ts

@ -4,12 +4,12 @@ import {
ChangeDetectionStrategy, ChangeDetectionStrategy,
ChangeDetectorRef, ChangeDetectorRef,
Component, Component,
DoCheck,
ElementRef, ElementRef,
Input, Input,
OnDestroy, OnDestroy,
OnInit, OnInit,
ViewChild, ViewChild
DoCheck
} from '@angular/core'; } from '@angular/core';
import { import {
FormControl, FormControl,
@ -59,7 +59,7 @@ import { AbstractMatFormField } from '../shared/abstract-mat-form-field';
}) })
export class GfCurrencySelectorComponent export class GfCurrencySelectorComponent
extends AbstractMatFormField<string> extends AbstractMatFormField<string>
implements OnInit, OnDestroy, DoCheck implements DoCheck, OnDestroy, OnInit
{ {
@Input() private currencies: string[] = []; @Input() private currencies: string[] = [];
@Input() private formControlName: string; @Input() private formControlName: string;

6
libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts

@ -8,14 +8,14 @@ import {
ChangeDetectionStrategy, ChangeDetectionStrategy,
ChangeDetectorRef, ChangeDetectorRef,
Component, Component,
DoCheck,
ElementRef, ElementRef,
Input, Input,
OnChanges, OnChanges,
OnDestroy, OnDestroy,
OnInit, OnInit,
SimpleChanges, SimpleChanges,
ViewChild, ViewChild
DoCheck
} from '@angular/core'; } from '@angular/core';
import { import {
FormControl, FormControl,
@ -77,7 +77,7 @@ import { AbstractMatFormField } from '../shared/abstract-mat-form-field';
}) })
export class GfSymbolAutocompleteComponent export class GfSymbolAutocompleteComponent
extends AbstractMatFormField<LookupItem> extends AbstractMatFormField<LookupItem>
implements OnChanges, OnDestroy, OnInit, DoCheck implements DoCheck, OnChanges, OnDestroy, OnInit
{ {
@Input() public defaultLookupItems: LookupItem[] = []; @Input() public defaultLookupItems: LookupItem[] = [];
@Input() public isLoading = false; @Input() public isLoading = false;

Loading…
Cancel
Save