Browse Source

Fix value redaction

bugfix/value-redaction-in-latest-activities-of-public-portfolio-page
Thomas Kaul 16 hours ago
parent
commit
29b2946f83
  1. 9
      apps/api/src/app/endpoints/public/public.service.ts
  2. 4
      libs/common/src/lib/config.ts
  3. 5
      libs/common/src/lib/interfaces/responses/public-portfolio-response.interface.ts

9
apps/api/src/app/endpoints/public/public.service.ts

@ -110,7 +110,6 @@ export class PublicService {
valueInBaseCurrency
}) => {
return {
assetProfile,
currency,
date,
fee,
@ -118,7 +117,13 @@ export class PublicService {
type,
unitPrice,
value,
valueInBaseCurrency
valueInBaseCurrency,
assetProfile: {
currency: assetProfile.currency,
dataSource: assetProfile.dataSource,
name: assetProfile.name,
symbol: assetProfile.symbol
}
};
}
);

4
libs/common/src/lib/config.ts

@ -157,6 +157,10 @@ export const DEFAULT_REDACTED_PATHS = [
'holdings[*].valueInBaseCurrency',
'interestInBaseCurrency',
'investmentInBaseCurrencyWithCurrencyEffect',
'latestActivities[*].fee',
'latestActivities[*].quantity',
'latestActivities[*].value',
'latestActivities[*].valueInBaseCurrency',
'netPerformance',
'netPerformanceWithCurrencyEffect',
'platforms[*].balance',

5
libs/common/src/lib/interfaces/responses/public-portfolio-response.interface.ts

@ -24,7 +24,10 @@ export interface PublicPortfolioResponse extends PublicPortfolioResponseV1 {
Order,
'currency' | 'date' | 'fee' | 'quantity' | 'type' | 'unitPrice'
> & {
assetProfile?: EnhancedAssetProfile;
assetProfile?: Pick<
EnhancedAssetProfile,
'currency' | 'dataSource' | 'name' | 'symbol'
>;
value: number;
valueInBaseCurrency: number;
})[];

Loading…
Cancel
Save