Browse Source

Code review fixes

pull/4892/head
csehatt741 3 weeks ago
committed by Thomas Kaul
parent
commit
31e742b822
  1. 38
      apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts
  2. 3
      libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts

38
apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts

@ -96,22 +96,28 @@ export class CreateOrUpdateActivityDialog implements OnDestroy {
.sort((a, b) => {
return a.name?.localeCompare(b.name);
})
.map((holding) => {
return {
assetClass: holding.assetClass,
assetSubClass: holding.assetSubClass,
currency: holding.currency,
dataProviderInfo: {
dataSource: holding.dataSource,
isPremium: false,
name: holding.name,
url: holding.url
},
dataSource: holding.dataSource,
name: holding.name,
symbol: holding.symbol
};
});
.map(
({
assetClass,
assetSubClass,
currency,
dataSource,
name,
symbol
}) => {
return {
assetClass,
assetSubClass,
currency,
dataProviderInfo: {
isPremium: false
},
dataSource,
name,
symbol
};
}
);
});
this.tagsAvailable =

3
libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts

@ -12,6 +12,7 @@ import {
Component,
ElementRef,
Input,
OnChanges,
OnDestroy,
OnInit,
SimpleChanges,
@ -75,7 +76,7 @@ import { GfPremiumIndicatorComponent } from '../premium-indicator';
})
export class GfSymbolAutocompleteComponent
extends AbstractMatFormField<LookupItem>
implements OnInit, OnDestroy
implements OnChanges, OnDestroy, OnInit
{
@Input() public defaultLookupItems: LookupItem[] = [];
@Input() public isLoading = false;

Loading…
Cancel
Save