applied feedback

- Icon Change from reader-outline to code-slash-outline for the Scraper Configuration tab
- Form Persistence Fix
    - Removed the nested <form> tag in the Scraper Configuration tab that was causing the "Form submission canceled because the form is not connected" warning
    - The scraper configuration fields are now properly connected to the main assetProfileForm through the formGroupName directive

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Extracted the scraper configuration to a dedicated tab in the asset profile dialog of the admin control panel
 - Lifted the asset profile identifier editing restriction for `MANUAL` data sources in the asset profile details dialog of the admin control panel
 - Upgraded `angular` from version `20.2.4` to `20.3.9`
 - Upgraded `Nx` from version `21.5.1` to `22.1.3`

apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts

@@ -78,6 +78,7 @@ import { format } from 'date-fns';
 import { StatusCodes } from 'http-status-codes';
 import { addIcons } from 'ionicons';
 import {
+  codeSlashOutline,
   createOutline,
   ellipsisVertical,
   readerOutline,
@@ -252,7 +253,13 @@ export class GfAssetProfileDialogComponent implements OnDestroy, OnInit {
     private snackBar: MatSnackBar,
     private userService: UserService
   ) {
-    addIcons({ createOutline, ellipsisVertical, readerOutline, serverOutline });
+    addIcons({
+      codeSlashOutline,
+      createOutline,
+      ellipsisVertical,
+      readerOutline,
+      serverOutline
+    });
   }
 
   public get canSaveAssetProfileIdentifier() {

apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html

@@ -467,11 +467,11 @@
       @if (assetProfile?.dataSource === 'MANUAL') {
         <mat-tab>
           <ng-template mat-tab-label>
-            <ion-icon name="reader-outline" />
+            <ion-icon name="code-slash-outline" />
             <div class="d-none d-sm-block ml-2" i18n>Scraper Configuration</div>
           </ng-template>
           <div class="container mt-3 p-0">
-            <form [formGroup]="assetProfileForm">
+            <div [formGroup]="assetProfileForm">
               <div formGroupName="scraperConfiguration">
                 <div class="mt-3">
                   <mat-form-field
@@ -569,7 +569,7 @@
                   </button>
                 </div>
               </div>
-            </form>
+            </div>
           </div>
         </mat-tab>
       }