Browse Source

Bugfix/fix unit in overview of home page (#2626)

* Fix unit

* Update changelog
pull/2629/head
Thomas Kaul 1 year ago
committed by GitHub
parent
commit
3a66ccdebe
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      CHANGELOG.md
  2. 6
      apps/client/src/app/components/home-overview/home-overview.component.ts

3
CHANGELOG.md

@ -9,13 +9,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed ### Fixed
- Fixed the unit for the _Zen Mode_ in the overview tab of the home page
- Fixed an issue to get quotes in the _Financial Modeling Prep_ service - Fixed an issue to get quotes in the _Financial Modeling Prep_ service
## 2.20.0 - 2023-11-08 ## 2.20.0 - 2023-11-08
### Changed ### Changed
- Removed the loading indicator of the unit on the overview tab of the home page - Removed the loading indicator of the unit in the overview tab of the home page
- Improved the import of historical market data in the admin control panel - Improved the import of historical market data in the admin control panel
- Increased the timeout in the health check endpoint for data enhancers - Increased the timeout in the health check endpoint for data enhancers
- Increased the timeout in the health check endpoint for data providers - Increased the timeout in the health check endpoint for data providers

6
apps/client/src/app/components/home-overview/home-overview.component.ts

@ -70,10 +70,6 @@ export class HomeOverviewComponent implements OnDestroy, OnInit {
.subscribe((impersonationId) => { .subscribe((impersonationId) => {
this.hasImpersonationId = !!impersonationId; this.hasImpersonationId = !!impersonationId;
this.unit = this.hasImpersonationId
? '%'
: this.user?.settings?.baseCurrency;
this.changeDetectorRef.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
@ -81,6 +77,8 @@ export class HomeOverviewComponent implements OnDestroy, OnInit {
!this.hasImpersonationId && !this.hasImpersonationId &&
!this.user.settings.isRestrictedView && !this.user.settings.isRestrictedView &&
this.user.settings.viewMode !== 'ZEN'; this.user.settings.viewMode !== 'ZEN';
this.unit = this.showDetails ? this.user.settings.baseCurrency : '%';
} }
public onChangeDateRange(dateRange: DateRange) { public onChangeDateRange(dateRange: DateRange) {

Loading…
Cancel
Save