Merge pull request #176 from dandevaud/feature/Use-total-investment-in-calculation

Smaller fixes for New Calculator (position performance)

apps/api/src/app/portfolio/calculator/roi/portfolio-calculator-symbolmetrics-helper.ts

@@ -59,20 +59,11 @@ export class RoiPortfolioCalculatorSymbolMetricsHelper {
                 new Big(0))
         ) ?? new Big(0);
 
-      let investmentBasis =
+      const investmentBasis = this.calculateInvestmentBasis(
-        symbolMetricsHelper.symbolMetrics.currentValuesWithCurrencyEffect[
+        symbolMetricsHelper,
-          rangeStartDateString
+        rangeStartDateString,
-        ];
+        rangeEndDateString
-
+      );
-      if (
-        !symbolMetricsHelper.symbolMetrics.currentValuesWithCurrencyEffect[
-          rangeStartDateString
-        ]?.gt(0)
-      ) {
-        investmentBasis =
-          symbolMetricsHelper.symbolMetrics
-            .timeWeightedInvestmentValuesWithCurrencyEffect[rangeEndDateString];
-      }
 
       symbolMetricsHelper.symbolMetrics.netPerformancePercentageWithCurrencyEffectMap[
         dateRange
@@ -865,4 +856,39 @@ export class RoiPortfolioCalculatorSymbolMetricsHelper {
       symbolMetricsHelper.exchangeRateAtOrderDate
     );
   }
+
+  private calculateInvestmentBasis(
+    symbolMetricsHelper: PortfolioCalculatorSymbolMetricsHelperObject,
+    rangeStartDateString: string,
+    rangeEndDateString: string
+  ) {
+    let investmentBasis = this.getValueOrZero(
+      symbolMetricsHelper.symbolMetrics.currentValuesWithCurrencyEffect[
+        rangeStartDateString
+      ]
+    ).plus(
+      this.getValueOrZero(
+        symbolMetricsHelper.symbolMetrics
+          .timeWeightedInvestmentValuesWithCurrencyEffect[rangeEndDateString]
+      )?.minus(
+        this.getValueOrZero(
+          symbolMetricsHelper.symbolMetrics
+            .timeWeightedInvestmentValuesWithCurrencyEffect[
+            rangeStartDateString
+          ]
+        )
+      )
+    );
+
+    if (!investmentBasis.gt(0)) {
+      investmentBasis =
+        symbolMetricsHelper.symbolMetrics
+          .timeWeightedInvestmentValuesWithCurrencyEffect[rangeEndDateString];
+    }
+    return investmentBasis;
+  }
+
+  private getValueOrZero(value: Big | undefined) {
+    return value ?? new Big(0);
+  }
 }

apps/api/src/app/portfolio/portfolio.service.ts

@@ -248,16 +248,18 @@ export class PortfolioService {
     activities: Activity[];
     groupBy?: GroupBy;
   }): Promise<InvestmentItem[]> {
-    let dividends = activities.map(({ currency, date, value }) => {
+    let dividends = activities.map(
-      return {
+      ({ currency, date, value, SymbolProfile }) => {
-        date: format(date, DATE_FORMAT),
+        return {
-        investment: this.exchangeRateDataService.toCurrency(
+          date: format(date, DATE_FORMAT),
-          value,
+          investment: this.exchangeRateDataService.toCurrency(
-          currency,
+            value,
-          this.getUserCurrency()
+            currency ?? SymbolProfile.currency,
-        )
+            this.getUserCurrency()
-      };
+          )
-    });
+        };
+      }
+    );
 
     if (groupBy) {
       dividends = this.getDividendsByGroup({ dividends, groupBy });