Browse Source

Task/set change detection strategy to OnPush in various dialog components (#7233)

* Set change detection strategy to OnPush

* Update changelog
pull/7235/head
Thomas Kaul 1 week ago
committed by GitHub
parent
commit
3ea21707b0
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 3
      CHANGELOG.md
  2. 3
      libs/ui/src/lib/notifications/alert-dialog/alert-dialog.component.ts
  3. 8
      libs/ui/src/lib/notifications/confirmation-dialog/confirmation-dialog.component.ts
  4. 3
      libs/ui/src/lib/notifications/prompt-dialog/prompt-dialog.component.ts

3
CHANGELOG.md

@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- Set the change detection strategy to `OnPush` in the alert dialog component
- Set the change detection strategy to `OnPush` in the confirmation dialog component
- Set the change detection strategy to `OnPush` in the prompt dialog component
- Upgraded `stripe` from version `21.0.1` to `22.2.3` - Upgraded `stripe` from version `21.0.1` to `22.2.3`
### Fixed ### Fixed

3
libs/ui/src/lib/notifications/alert-dialog/alert-dialog.component.ts

@ -1,10 +1,11 @@
import { Component, inject } from '@angular/core'; import { ChangeDetectionStrategy, Component, inject } from '@angular/core';
import { MatButtonModule } from '@angular/material/button'; import { MatButtonModule } from '@angular/material/button';
import { MatDialogModule, MatDialogRef } from '@angular/material/dialog'; import { MatDialogModule, MatDialogRef } from '@angular/material/dialog';
import { AlertDialogParams } from './interfaces/interfaces'; import { AlertDialogParams } from './interfaces/interfaces';
@Component({ @Component({
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [MatButtonModule, MatDialogModule], imports: [MatButtonModule, MatDialogModule],
selector: 'gf-alert-dialog', selector: 'gf-alert-dialog',
styleUrls: ['./alert-dialog.scss'], styleUrls: ['./alert-dialog.scss'],

8
libs/ui/src/lib/notifications/confirmation-dialog/confirmation-dialog.component.ts

@ -1,12 +1,18 @@
import { ConfirmationDialogType } from '@ghostfolio/common/enums'; import { ConfirmationDialogType } from '@ghostfolio/common/enums';
import { Component, HostListener, inject } from '@angular/core'; import {
ChangeDetectionStrategy,
Component,
HostListener,
inject
} from '@angular/core';
import { MatButtonModule } from '@angular/material/button'; import { MatButtonModule } from '@angular/material/button';
import { MatDialogModule, MatDialogRef } from '@angular/material/dialog'; import { MatDialogModule, MatDialogRef } from '@angular/material/dialog';
import { ConfirmDialogParams } from './interfaces/interfaces'; import { ConfirmDialogParams } from './interfaces/interfaces';
@Component({ @Component({
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [MatButtonModule, MatDialogModule], imports: [MatButtonModule, MatDialogModule],
selector: 'gf-confirmation-dialog', selector: 'gf-confirmation-dialog',
styleUrls: ['./confirmation-dialog.scss'], styleUrls: ['./confirmation-dialog.scss'],

3
libs/ui/src/lib/notifications/prompt-dialog/prompt-dialog.component.ts

@ -1,4 +1,4 @@
import { Component, inject } from '@angular/core'; import { ChangeDetectionStrategy, Component, inject } from '@angular/core';
import { FormControl, ReactiveFormsModule } from '@angular/forms'; import { FormControl, ReactiveFormsModule } from '@angular/forms';
import { MatButtonModule } from '@angular/material/button'; import { MatButtonModule } from '@angular/material/button';
import { MatDialogModule, MatDialogRef } from '@angular/material/dialog'; import { MatDialogModule, MatDialogRef } from '@angular/material/dialog';
@ -8,6 +8,7 @@ import { MatInputModule } from '@angular/material/input';
import { PromptDialogParams } from './interfaces/interfaces'; import { PromptDialogParams } from './interfaces/interfaces';
@Component({ @Component({
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [ imports: [
MatButtonModule, MatButtonModule,
MatDialogModule, MatDialogModule,

Loading…
Cancel
Save