Browse Source

Fix value redaction

bugfix/value-redaction-in-latest-activities-of-public-portfolio-page
Thomas Kaul 15 hours ago
parent
commit
473e236819
  1. 12
      apps/api/src/app/endpoints/public/public.service.ts
  2. 1
      apps/api/src/interceptors/transform-data-source-in-response/transform-data-source-in-response.interceptor.ts
  3. 2
      libs/common/src/lib/interfaces/responses/public-portfolio-response.interface.ts

12
apps/api/src/app/endpoints/public/public.service.ts

@ -81,6 +81,10 @@ export class PublicService {
}) })
]); ]);
// Experimental
let latestActivities: PublicPortfolioResponse['latestActivities'] = [];
if (!this.configurationService.get('ENABLE_FEATURE_SUBSCRIPTION')) {
const { activities } = await this.activitiesService.getActivities({ const { activities } = await this.activitiesService.getActivities({
filters, filters,
sortColumn: 'date', sortColumn: 'date',
@ -92,12 +96,7 @@ export class PublicService {
withExcludedAccountsAndActivities: false withExcludedAccountsAndActivities: false
}); });
// Experimental latestActivities = activities.map(
const latestActivities = this.configurationService.get(
'ENABLE_FEATURE_SUBSCRIPTION'
)
? []
: activities.map(
({ ({
assetProfile, assetProfile,
currency, currency,
@ -127,6 +126,7 @@ export class PublicService {
}; };
} }
); );
}
Object.values(markets ?? {}).forEach((market) => { Object.values(markets ?? {}).forEach((market) => {
delete market.valueInBaseCurrency; delete market.valueInBaseCurrency;

1
apps/api/src/interceptors/transform-data-source-in-response/transform-data-source-in-response.interceptor.ts

@ -89,6 +89,7 @@ export class TransformDataSourceInResponseInterceptor<
'holdings[*].assetProfile.dataSource', 'holdings[*].assetProfile.dataSource',
'holdings[*].dataSource', 'holdings[*].dataSource',
'items[*].dataSource', 'items[*].dataSource',
'latestActivities[*].assetProfile.dataSource',
'settings["filters.dataSource"]', 'settings["filters.dataSource"]',
'watchlist[*].dataSource' 'watchlist[*].dataSource'
] ]

2
libs/common/src/lib/interfaces/responses/public-portfolio-response.interface.ts

@ -24,7 +24,7 @@ export interface PublicPortfolioResponse extends PublicPortfolioResponseV1 {
Order, Order,
'currency' | 'date' | 'fee' | 'quantity' | 'type' | 'unitPrice' 'currency' | 'date' | 'fee' | 'quantity' | 'type' | 'unitPrice'
> & { > & {
assetProfile?: Pick< assetProfile: Pick<
EnhancedAssetProfile, EnhancedAssetProfile,
'currency' | 'dataSource' | 'name' | 'symbol' 'currency' | 'dataSource' | 'name' | 'symbol'
>; >;

Loading…
Cancel
Save